Bug 1530699 - Apply breakpoints to all discovered sources, r=loganfsmyth.
authorBrian Hackett <bhackett1024@gmail.com>
Tue, 05 Mar 2019 15:56:00 -1000
changeset 520792 43963f700a1e06a01d46158177dccd3c3987c9c0
parent 520791 a52dffe6d7beee0a0ad9dca59ab504593018d00d
child 520793 a96130bc4159d683e559b763d18d36bc5d4b2b44
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersloganfsmyth
bugs1530699
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1530699 - Apply breakpoints to all discovered sources, r=loganfsmyth.
devtools/server/actors/thread.js
--- a/devtools/server/actors/thread.js
+++ b/devtools/server/actors/thread.js
@@ -1136,20 +1136,18 @@ const ThreadActor = ActorClassWithSpec(t
       } else if (actor.destroy) {
         actor.destroy();
       }
     }
     return res ? res : {};
   },
 
   onSources: function(request) {
-    // FIXME bug 1530699 we should make sure that existing breakpoints are
-    // applied to any sources we find here.
     for (const source of this.dbg.findSources()) {
-      this.sources.createSourceActor(source);
+      this._addSource(source);
     }
 
     // No need to flush the new source packets here, as we are sending the
     // list of sources out immediately and we don't need to invoke the
     // overhead of an RDP packet for every source right now. Let the default
     // timeout flush the buffered packets.
 
     return {