Bug 1454398 - Disable asserts responsible for intermittent failures. r=me
authorJan de Mooij <jdemooij@mozilla.com>
Wed, 18 Apr 2018 10:40:24 +0200
changeset 467764 42e037e0b8d1d774db5cc38ef486639c1c2889f1
parent 467763 dbf2bfc0aea9754a44ae6e1c779b82ea84474dff
child 467765 4af4ae0aee552a99a995ce4b32198b98294a95f7
child 467810 8306e1afdb9b05a6764100999c6c33e9ff18c40d
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1454398
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1454398 - Disable asserts responsible for intermittent failures. r=me
js/src/vm/TypeInference.cpp
--- a/js/src/vm/TypeInference.cpp
+++ b/js/src/vm/TypeInference.cpp
@@ -4322,17 +4322,17 @@ EnsureHasAutoClearTypeInferenceStateOnOO
  * objects are accessed before their contents have been swept.
  */
 void
 ObjectGroup::sweep(AutoClearTypeInferenceStateOnOOM* oom)
 {
     MOZ_ASSERT(generation() != zoneFromAnyThread()->types.generation);
     setGeneration(zone()->types.generation);
 
-    MOZ_RELEASE_ASSERT(!zone()->types.assertNoTISweeping);
+    // Bug 1454398, MOZ_RELEASE_ASSERT(!zone()->types.assertNoTISweeping);
 
     AssertGCStateForSweep(zone());
 
     Maybe<AutoClearTypeInferenceStateOnOOM> fallbackOOM;
     EnsureHasAutoClearTypeInferenceStateOnOOM(oom, zone(), fallbackOOM);
 
     AutoTouchingGrayThings tgt;
 
@@ -4448,17 +4448,17 @@ ObjectGroup::sweep(AutoClearTypeInferenc
 /* static */ void
 JSScript::maybeSweepTypes(AutoClearTypeInferenceStateOnOOM* oom)
 {
     MOZ_ASSERT(!TlsContext.get()->inUnsafeCallWithABI);
 
     if (!types_ || typesGeneration() == zone()->types.generation)
         return;
 
-    MOZ_RELEASE_ASSERT(!zone()->types.assertNoTISweeping);
+    // Bug 1454398, MOZ_RELEASE_ASSERT(!zone()->types.assertNoTISweeping);
 
     setTypesGeneration(zone()->types.generation);
 
     AssertGCStateForSweep(zone());
 
     Maybe<AutoClearTypeInferenceStateOnOOM> fallbackOOM;
     EnsureHasAutoClearTypeInferenceStateOnOOM(oom, zone(), fallbackOOM);