Bug 835219 - Get rid of nsSVGMarkerElement's GetAttr() override. r=longsonr.
authorJonathan Watt <jwatt@jwatt.org>
Tue, 29 Jan 2013 11:26:19 +0000
changeset 130236 4207c7cf71a85454db9025469b08b4e6f021f4c0
parent 130227 8aac8445c2bb730e2a5ee22a01074e41f16579a7
child 130237 220a6ba702cb3aa1b7a7d06c97430db03866a951
push id2323
push userbbajaj@mozilla.com
push dateMon, 01 Apr 2013 19:47:02 +0000
treeherdermozilla-beta@7712be144d91 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslongsonr
bugs835219
milestone21.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 835219 - Get rid of nsSVGMarkerElement's GetAttr() override. r=longsonr.
content/svg/content/src/SVGMarkerElement.cpp
content/svg/content/src/SVGMarkerElement.h
--- a/content/svg/content/src/SVGMarkerElement.cpp
+++ b/content/svg/content/src/SVGMarkerElement.cpp
@@ -287,29 +287,16 @@ SVGMarkerElement::IsAttributeMapped(cons
   return FindAttributeDependence(name, map) ||
     SVGMarkerElementBase::IsAttributeMapped(name);
 }
 
 //----------------------------------------------------------------------
 // nsSVGElement methods
 
 bool
-SVGMarkerElement::GetAttr(int32_t aNameSpaceID, nsIAtom* aName,
-                          nsAString &aResult) const
-{
-  if (aNameSpaceID == kNameSpaceID_None &&
-      aName == nsGkAtoms::orient &&
-      mOrientType.GetBaseValue() == SVG_MARKER_ORIENT_AUTO) {
-    aResult.AssignLiteral("auto");
-    return true;
-  }
-  return SVGMarkerElementBase::GetAttr(aNameSpaceID, aName, aResult);
-}
-
-bool
 SVGMarkerElement::ParseAttribute(int32_t aNameSpaceID, nsIAtom* aName,
                                  const nsAString& aValue,
                                  nsAttrValue& aResult)
 {
   if (aNameSpaceID == kNameSpaceID_None && aName == nsGkAtoms::orient) {
     if (aValue.EqualsLiteral("auto")) {
       mOrientType.SetBaseValue(SVG_MARKER_ORIENT_AUTO);
       aResult.SetTo(aValue);
--- a/content/svg/content/src/SVGMarkerElement.h
+++ b/content/svg/content/src/SVGMarkerElement.h
@@ -97,18 +97,16 @@ public:
   // xxx I wish we could use virtual inheritance
   NS_FORWARD_NSIDOMNODE_TO_NSINODE
   NS_FORWARD_NSIDOMELEMENT_TO_GENERIC
   NS_FORWARD_NSIDOMSVGELEMENT(nsSVGElement::)
 
   // nsIContent interface
   NS_IMETHOD_(bool) IsAttributeMapped(const nsIAtom* name) const;
 
-  virtual bool GetAttr(int32_t aNameSpaceID, nsIAtom* aName,
-                         nsAString& aResult) const;
   virtual nsresult UnsetAttr(int32_t aNameSpaceID, nsIAtom* aAttribute,
                              bool aNotify);
 
   // nsSVGSVGElement methods:
   virtual bool HasValidDimensions() const;
 
   // public helpers
   gfxMatrix GetMarkerTransform(float aStrokeWidth,