Bug 1009529 - Treat null features as '' features in window.open calls. r=bz, a=sledru
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Tue, 13 May 2014 19:08:34 +0100
changeset 192284 41a1653a0199
parent 192283 542398357372
child 192285 c3db2214834e
push id3557
push userryanvm@gmail.com
push date2014-05-14 16:23 +0000
treeherdermozilla-beta@c3bcd563e6ce [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbz, sledru
bugs1009529
milestone30.0
Bug 1009529 - Treat null features as '' features in window.open calls. r=bz, a=sledru
dom/webidl/Window.webidl
--- a/dom/webidl/Window.webidl
+++ b/dom/webidl/Window.webidl
@@ -51,18 +51,18 @@ typedef any Transferable;
   // other browsing contexts
   [Replaceable, Throws, CrossOriginReadable] readonly attribute WindowProxy frames;
   [Replaceable, CrossOriginReadable] readonly attribute unsigned long length;
   [Unforgeable, Throws, CrossOriginReadable] readonly attribute WindowProxy top;
   [Throws, CrossOriginReadable] attribute WindowProxy? opener;
   //[Throws] readonly attribute WindowProxy parent;
   [Replaceable, Throws, CrossOriginReadable] readonly attribute WindowProxy? parent;
   [Throws] readonly attribute Element? frameElement;
-  //[Throws] WindowProxy open(optional DOMString url = "about:blank", optional DOMString target = "_blank", optional DOMString features = "", optional boolean replace = false);
-  [Throws] WindowProxy? open(optional DOMString url = "", optional DOMString target = "", optional DOMString features = "");
+  //[Throws] WindowProxy open(optional DOMString url = "about:blank", optional DOMString target = "_blank", [TreatNullAs=EmptyString] optional DOMString features = "", optional boolean replace = false);
+  [Throws] WindowProxy? open(optional DOMString url = "", optional DOMString target = "", [TreatNullAs=EmptyString] optional DOMString features = "");
   // We think the indexed getter is a bug in the spec, it actually needs to live
   // on the WindowProxy
   //getter WindowProxy (unsigned long index);
   //getter object (DOMString name);
 
   // the user agent
   [Throws] readonly attribute Navigator navigator; 
   //(Not implemented)readonly attribute External external;