Backed out changeset fc5c57e9b65b (bug 1484595) for linting failure on a CLOSED TREE
authorshindli <shindli@mozilla.com>
Mon, 20 Aug 2018 10:38:08 +0300
changeset 487412 41993cf46d6ab0a21976edc9bbb3b69891684fb4
parent 487411 5bc36aec6368b3ae076d7b6cc7e821b3fc260385
child 487417 77433149bfdcc82287acaed94b942818785b556e
child 487418 655d8b94c8f1f78185f51a11ff0d30f929ac5016
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1484595
milestone63.0a1
backs outfc5c57e9b65b65e98fdc8e792913a5553bb67897
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset fc5c57e9b65b (bug 1484595) for linting failure on a CLOSED TREE
devtools/client/shared/components/menu/MenuButton.js
--- a/devtools/client/shared/components/menu/MenuButton.js
+++ b/devtools/client/shared/components/menu/MenuButton.js
@@ -121,18 +121,18 @@ class MenuButton extends PureComponent {
   async resetTooltip() {
     if (!this.tooltip) {
       return;
     }
 
     // Mark the menu as closed since the onHidden callback may not be called in
     // this case.
     this.setState({ expanded: false });
+    this.tooltip.destroy();
     this.tooltip.off("hidden", this.onHidden);
-    this.tooltip.destroy();
     this.tooltip = null;
   }
 
   async showMenu(anchor) {
     this.setState({
       expanded: true
     });