Bug 1483989 [wpt PR 12533] - Re-enable the Background Fetch WPT tests, a=testonly
authorPeter Beverloo <peter@chromium.org>
Mon, 20 Aug 2018 22:09:16 +0000
changeset 487797 41966d1c0faad97fcbe0b6909fc05a9ca0e5b944
parent 487796 f6749ea61079f8633a21bf2b178927e6b7ab9b65
child 487798 d267941739e09595fc8343a0e365290aed1c1740
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1483989, 12533, 1165554, 869470, 869818, 1170909, 583729
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1483989 [wpt PR 12533] - Re-enable the Background Fetch WPT tests, a=testonly Automatic update from web-platform-testsRe-enable the Background Fetch WPT tests The flaky crashes should have been fixed now that the associated logic has been removed from the scheduler. https://chromium-review.googlesource.com/c/chromium/src/+/1165554 Bug: 869470, 869818 Change-Id: Ie077876289a28387e5f890e9a25abe5609857c14 Reviewed-on: https://chromium-review.googlesource.com/1170909 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#583729} -- wpt-commits: f4cfe41feec71829ec58aa0bf8ef3b8bf489dc7f wpt-pr: 12533
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/background-fetch/fetch.https.window.js
testing/web-platform/tests/background-fetch/get-ids.https.window.js
testing/web-platform/tests/background-fetch/get.https.window.js
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -432596,25 +432596,25 @@
    "0b5b1cb5e94d3f27bebbb5a462bf1e823dfc57b4",
    "testharness"
   ],
   "background-fetch/dangling-markup.https.window.js": [
    "764257d7d1a8eecfba6735647637055b21dcb94b",
    "testharness"
   ],
   "background-fetch/fetch.https.window.js": [
-   "f146212987a4ebb2e90edc190e9232cbd07210f9",
+   "843506947f7176761f0d47b9a7fa83ab187322b1",
    "testharness"
   ],
   "background-fetch/get-ids.https.window.js": [
-   "28f5bc3132b7209c343ee264fb0699184e7bb47c",
+   "4c8bf26190719108e65b446a34aafe0aeb1377be",
    "testharness"
   ],
   "background-fetch/get.https.window.js": [
-   "0b272dbaa4961b73049325f7826713682b590f8c",
+   "a0b2acd4a6955274e3e05e9666f0c6182f07404f",
    "testharness"
   ],
   "background-fetch/idlharness.https.any.js": [
    "f2c8a56590aedc52051e7ad8f51b3725091821dc",
    "testharness"
   ],
   "background-fetch/mixed-content-and-allowed-schemes.https.window.js": [
    "9f24f13581819ef444a89cb7549de900f5b98ef6",
--- a/testing/web-platform/tests/background-fetch/fetch.https.window.js
+++ b/testing/web-platform/tests/background-fetch/fetch.https.window.js
@@ -3,30 +3,30 @@
 'use strict';
 
 // Covers basic functionality provided by BackgroundFetchManager.fetch().
 // https://wicg.github.io/background-fetch/#background-fetch-manager-fetch
 
 promise_test(async test => {
   // 6.3.1.9.2: If |registration|’s active worker is null, then reject promise
   //            with a TypeError and abort these steps.
-  const script = 'resources/sw.js';
-  const scope = 'resources/scope' + location.pathname;
+  const script = 'service_workers/sw.js';
+  const scope = 'service_workers/' + location.pathname;
 
   const serviceWorkerRegistration =
       await service_worker_unregister_and_register(test, script, scope);
 
   assert_equals(
       serviceWorkerRegistration.active, null,
       'There must not be an activated worker');
 
   await promise_rejects(
       test, new TypeError(),
       serviceWorkerRegistration.backgroundFetch.fetch(
-          uniqueId(), ['resources/sw.js']),
+          uniqueId(), ['resources/feature-name.txt']),
       'fetch() must reject on pending and installing workers');
 
 }, 'Background Fetch requires an activated Service Worker');
 
 backgroundFetchTest(async (test, backgroundFetch) => {
   // 6.3.1.6: If |requests| is empty, then return a promise rejected with a
   //          TypeError.
   await promise_rejects(
@@ -39,30 +39,32 @@ backgroundFetchTest(async (test, backgro
   await promise_rejects(
       test, new TypeError(),
       backgroundFetch.fetch(uniqueId(), 'https://user:pass@domain/secret.txt'),
       'Exceptions thrown in the Request constructor are rethrown');
 
   // 6.3.1.7.2: If |internalRequest|’s mode is "no-cors", then return a
   //            promise rejected with a TypeError.
   {
-    const request = new Request('resources/sw.js', {mode: 'no-cors'});
+    const request =
+        new Request('resources/feature-name.txt', {mode: 'no-cors'});
+
     await promise_rejects(
         test, new TypeError(), backgroundFetch.fetch(uniqueId(), request),
         'Requests must not be in no-cors mode');
   }
 
 }, 'Argument verification is done for BackgroundFetchManager.fetch()');
 
 backgroundFetchTest(async (test, backgroundFetch) => {
   // 6.3.1.9.2: If |bgFetchMap[id]| exists, reject |promise| with a TypeError
   //            and abort these steps.
   return promise_rejects(test, new TypeError(), Promise.all([
-    backgroundFetch.fetch('my-id', 'resources/sw.js'),
-    backgroundFetch.fetch('my-id', 'resources/feature-name.txt')
+    backgroundFetch.fetch('my-id', 'resources/feature-name.txt?1'),
+    backgroundFetch.fetch('my-id', 'resources/feature-name.txt?2')
   ]));
 
 }, 'IDs must be unique among active Background Fetch registrations');
 
 backgroundFetchTest(async (test, backgroundFetch) => {
   const registrationId = uniqueId();
   const registration =
       await backgroundFetch.fetch(registrationId, 'resources/feature-name.txt');
--- a/testing/web-platform/tests/background-fetch/get-ids.https.window.js
+++ b/testing/web-platform/tests/background-fetch/get-ids.https.window.js
@@ -3,18 +3,18 @@
 'use strict';
 
 // Covers functionality provided by BackgroundFetchManager.getIds(), which
 // exposes the keys of active background fetches.
 //
 // https://wicg.github.io/background-fetch/#background-fetch-manager-getIds
 
 promise_test(async test => {
-  const script = 'resources/sw.js';
-  const scope = 'resources/scope' + location.pathname;
+  const script = 'service_workers/sw.js';
+  const scope = 'service_workers/' + location.pathname;
 
   const serviceWorkerRegistration =
       await service_worker_unregister_and_register(test, script, scope);
 
   assert_equals(
       serviceWorkerRegistration.active, null,
       'There must not be an activated worker');
 
--- a/testing/web-platform/tests/background-fetch/get.https.window.js
+++ b/testing/web-platform/tests/background-fetch/get.https.window.js
@@ -3,18 +3,18 @@
 'use strict';
 
 // Covers functionality provided by BackgroundFetchManager.get(), which
 // exposes the keys of active background fetches.
 //
 // https://wicg.github.io/background-fetch/#background-fetch-manager-get
 
 promise_test(async test => {
-  const script = 'resources/sw.js';
-  const scope = 'resources/scope' + location.pathname;
+  const script = 'service_workers/sw.js';
+  const scope = 'service_workers/' + location.pathname;
 
   const serviceWorkerRegistration =
       await service_worker_unregister_and_register(test, script, scope);
 
   assert_equals(
       serviceWorkerRegistration.active, null,
       'There must not be an activated worker');