Bug 1574502 - Sidebar panels should be collapsed by default. r=davidwalsh
authorJason Laster <jlaster@mozilla.com>
Mon, 26 Aug 2019 20:11:52 +0000
changeset 550445 41933c6deb8e10bb844e57f8d50f8874eb67a581
parent 550444 fdd1a25b68e1d43d41a77a3aaad0b330df51c36f
child 550446 85ac77f6cbcbc53296f97286a62e88279f158849
push id11858
push userrmaries@mozilla.com
push dateThu, 29 Aug 2019 15:29:30 +0000
treeherdermozilla-beta@e9268d2f3233 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdavidwalsh
bugs1574502
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1574502 - Sidebar panels should be collapsed by default. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D42317
devtools/client/debugger/src/utils/prefs.js
devtools/client/debugger/test/mochitest/browser_dbg-windowless-workers.js
devtools/client/preferences/debugger.js
--- a/devtools/client/debugger/src/utils/prefs.js
+++ b/devtools/client/debugger/src/utils/prefs.js
@@ -20,23 +20,23 @@ if (isDevelopment()) {
   pref("devtools.debugger.auto-pretty-print", false);
   pref("devtools.source-map.client-service.enabled", true);
   pref("devtools.chrome.enabled", false);
   pref("devtools.debugger.pause-on-exceptions", false);
   pref("devtools.debugger.pause-on-caught-exceptions", false);
   pref("devtools.debugger.ignore-caught-exceptions", true);
   pref("devtools.debugger.call-stack-visible", true);
   pref("devtools.debugger.scopes-visible", true);
-  pref("devtools.debugger.component-visible", true);
-  pref("devtools.debugger.workers-visible", true);
-  pref("devtools.debugger.expressions-visible", true);
-  pref("devtools.debugger.xhr-breakpoints-visible", true);
+  pref("devtools.debugger.component-visible", false);
+  pref("devtools.debugger.workers-visible", false);
+  pref("devtools.debugger.expressions-visible", false);
+  pref("devtools.debugger.xhr-breakpoints-visible", false);
   pref("devtools.debugger.breakpoints-visible", true);
-  pref("devtools.debugger.event-listeners-visible", true);
-  pref("devtools.debugger.dom-mutation-breakpoints-visible", true);
+  pref("devtools.debugger.event-listeners-visible", false);
+  pref("devtools.debugger.dom-mutation-breakpoints-visible", false);
   pref("devtools.debugger.start-panel-collapsed", false);
   pref("devtools.debugger.end-panel-collapsed", false);
   pref("devtools.debugger.start-panel-size", 300);
   pref("devtools.debugger.end-panel-size", 300);
   pref("devtools.debugger.tabsBlackBoxed", "[]");
   pref("devtools.debugger.ui.editor-wrapping", false);
   pref("devtools.debugger.ui.framework-grouping-on", true);
   pref("devtools.debugger.pending-selected-location", "{}");
--- a/devtools/client/debugger/test/mochitest/browser_dbg-windowless-workers.js
+++ b/devtools/client/debugger/test/mochitest/browser_dbg-windowless-workers.js
@@ -32,16 +32,19 @@ function getLabel(dbg, index) {
 
 function getValue(dbg, index) {
   return findElement(dbg, "expressionValue", index).innerText;
 }
 
 // Test basic windowless worker functionality: the main thread and worker can be
 // separately controlled from the same debugger.
 add_task(async function() {
+  await pushPref("devtools.debugger.features.windowless-workers", true);
+  await pushPref("devtools.debugger.workers-visible", true);
+
   const dbg = await initDebugger("doc-windowless-workers.html");
   const mainThread = dbg.toolbox.threadFront.actor;
 
   const workers = await getThreads(dbg);
   ok(workers.length == 2, "Got two workers");
   const thread1 = workers[0].actor;
   const thread2 = workers[1].actor;
 
--- a/devtools/client/preferences/debugger.js
+++ b/devtools/client/preferences/debugger.js
@@ -31,23 +31,23 @@ pref("devtools.debugger.ui.panes-instrum
 pref("devtools.debugger.ui.panes-visible-on-startup", false);
 pref("devtools.debugger.ui.variables-sorting-enabled", true);
 pref("devtools.debugger.ui.variables-only-enum-visible", false);
 pref("devtools.debugger.ui.variables-searchbox-visible", false);
 pref("devtools.debugger.ui.framework-grouping-on", true);
 pref("devtools.debugger.ui.editor-wrapping", false);
 pref("devtools.debugger.call-stack-visible", true);
 pref("devtools.debugger.scopes-visible", true);
-pref("devtools.debugger.component-visible", true);
-pref("devtools.debugger.workers-visible", true);
+pref("devtools.debugger.component-visible", false);
+pref("devtools.debugger.workers-visible", false);
 pref("devtools.debugger.breakpoints-visible", true);
-pref("devtools.debugger.expressions-visible", true);
-pref("devtools.debugger.dom-mutation-breakpoints-visible", true);
-pref("devtools.debugger.xhr-breakpoints-visible", true);
-pref("devtools.debugger.event-listeners-visible", true);
+pref("devtools.debugger.expressions-visible", false);
+pref("devtools.debugger.dom-mutation-breakpoints-visible", false);
+pref("devtools.debugger.xhr-breakpoints-visible", false);
+pref("devtools.debugger.event-listeners-visible", false);
 pref("devtools.debugger.start-panel-collapsed", false);
 pref("devtools.debugger.end-panel-collapsed", false);
 pref("devtools.debugger.start-panel-size", 300);
 pref("devtools.debugger.end-panel-size", 300);
 pref("devtools.debugger.tabs", "[]");
 pref("devtools.debugger.tabsBlackBoxed", "[]");
 pref("devtools.debugger.pending-selected-location", "{}");
 pref("devtools.debugger.pending-breakpoints", "{}");