Bug 1632319 - Remove soundplaying icon from tab when discarding browser. r=jaws
authorDão Gottwald <dao@mozilla.com>
Mon, 27 Apr 2020 23:49:35 +0000
changeset 589878 41018db33b428ca627039fc30d9db6ff05cd438f
parent 589877 6437d716c498d4b7492e7c22128f47aa61b8c1ca
child 589879 7fedd8fbdd5e35b0ee1ea1efd19f31706057d21f
push id13072
push userffxbld-merge
push dateMon, 04 May 2020 14:22:08 +0000
treeherdermozilla-beta@8a4f45b9a244 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1632319
milestone77.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1632319 - Remove soundplaying icon from tab when discarding browser. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D72656
browser/base/content/tabbrowser.js
--- a/browser/base/content/tabbrowser.js
+++ b/browser/base/content/tabbrowser.js
@@ -2436,18 +2436,23 @@
 
       // Reset the findbar and remove it if it is attached to the tab.
       if (aTab._findBar) {
         aTab._findBar.close(true);
         aTab._findBar.remove();
         delete aTab._findBar;
       }
 
-      // Remove stale loading attributes.
-      let attributesToRemove = ["busy", "progress", "pendingicon"];
+      // Remove potentially stale attributes.
+      let attributesToRemove = [
+        "busy",
+        "pendingicon",
+        "progress",
+        "soundplaying",
+      ];
       let removedAttributes = [];
       for (let attr of attributesToRemove) {
         if (aTab.hasAttribute(attr)) {
           removedAttributes.push(attr);
           aTab.removeAttribute(attr);
         }
       }
       if (removedAttributes.length) {