Bug 1455868: Expect unsigned langpack install to fail on release builds. r=aswan
authorKris Maglione <maglione.k@gmail.com>
Sat, 21 Apr 2018 16:40:23 -0700
changeset 468498 40e62bd007f76eefabd152b06ed1a9104180e0e9
parent 468497 894d7e5286e1cd81586232dcd18c2a3300f000d5
child 468499 bc824db66c5331d00f5de2fe0a39b5790a183513
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaswan
bugs1455868
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1455868: Expect unsigned langpack install to fail on release builds. r=aswan MozReview-Commit-ID: DpNa24d2T6U
toolkit/mozapps/extensions/test/xpcshell/test_signed_langpack.js
--- a/toolkit/mozapps/extensions/test/xpcshell/test_signed_langpack.js
+++ b/toolkit/mozapps/extensions/test/xpcshell/test_signed_langpack.js
@@ -43,14 +43,19 @@ add_task(async function() {
   let unsignedXPI = do_get_file("data/signing_checks/langpack_unsigned.xpi");
   await installShouldFail(unsignedXPI);
 
   // Even with the general xpi signing pref off, an unsigned langapck
   // should not install.
   Services.prefs.setBoolPref(PREF_SIGNATURES_GENERAL, false);
   await installShouldFail(unsignedXPI);
 
-  // But with the langpack signing pref off, unsigned langpack should isntall.
+  // But with the langpack signing pref off, unsigned langpack should
+  // install only on non-release builds.
   Services.prefs.setBoolPref(PREF_SIGNATURES_LANGPACKS, false);
-  await installShouldSucceed(unsignedXPI);
+  if (AppConstants.MOZ_REQUIRE_SIGNING) {
+    await installShouldFail(unsignedXPI);
+  } else {
+    await installShouldSucceed(unsignedXPI);
+  }
 
   await promiseShutdownManager();
 });