No Bug - Fix a warning introduced by bug 984361; r=jonco
authorTerrence Cole <terrence@mozilla.com>
Wed, 14 May 2014 09:15:46 -0700
changeset 202499 40bc628f60c4a9e8c69d207548004ef34d82453d
parent 202498 2ba9cda30f62362724f4b7e5f7a01464119a8ce0
child 202500 927185688195d5c6f78fa8b81fdb5e802cb22916
push id3741
push userasasaki@mozilla.com
push dateMon, 21 Jul 2014 20:25:18 +0000
treeherdermozilla-beta@4d6f46f5af68 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjonco
bugs984361
milestone32.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
No Bug - Fix a warning introduced by bug 984361; r=jonco
js/src/gc/Marking.cpp
--- a/js/src/gc/Marking.cpp
+++ b/js/src/gc/Marking.cpp
@@ -148,17 +148,19 @@ template <> bool ThingIsPermanentAtom<Pr
 
 template<typename T>
 static inline void
 CheckMarkedThing(JSTracer *trc, T **thingp)
 {
     JS_ASSERT(trc);
     JS_ASSERT(thingp);
 
+#if defined(JS_CRASH_DIAGNOSTICS) || defined(DEBUG)
     T *thing = *thingp;
+#endif
 
 #ifdef JS_CRASH_DIAGNOSTICS
     if (uintptr_t(thing) <= ArenaSize || (uintptr_t(thing) & 1) != 0) {
         char msgbuf[1024];
         const char *label = trc->tracingName("<unknown>");
         JS_snprintf(msgbuf, sizeof(msgbuf),
                     "[crash diagnostics] Marking invalid pointer %p @ %p of type %s, named \"%s\"",
                     thing, thingp, TraceKindAsAscii(MapTypeToTraceKind<T>::kind), label);