Bug 1512857 - Remove the additional padding in .button-box/.menulist-label-box from common.css buttons/menulists. r=dao, a=RyanVM
authorRichard Marti <richard.marti@gmail.com>
Wed, 12 Dec 2018 10:12:12 +0100
changeset 506214 405ee85a224774b173f440cf225f37108073c0ac
parent 506213 d48cfac9b2f00460a83549c07980769ee59c742f
child 506215 4a9792ce63e3011e473b9d33afdc686bdf47dec0
push id10333
push userryanvm@gmail.com
push dateThu, 13 Dec 2018 23:22:04 +0000
treeherdermozilla-beta@aea4a31fb8bb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao, RyanVM
bugs1512857
milestone65.0
Bug 1512857 - Remove the additional padding in .button-box/.menulist-label-box from common.css buttons/menulists. r=dao, a=RyanVM
toolkit/themes/shared/in-content/common.inc.css
toolkit/themes/windows/global/button.css
toolkit/themes/windows/global/in-content/common.css
--- a/toolkit/themes/shared/in-content/common.inc.css
+++ b/toolkit/themes/shared/in-content/common.inc.css
@@ -256,22 +256,16 @@ xul|button.primary:not([disabled="true"]
   background-color: var(--in-content-primary-button-background-active);
 }
 
 html|input[type="color"] {
   padding: 6px;
   width: 50px;
 }
 
-xul|button > xul|*.button-box,
-xul|menulist > xul|*.menulist-label-box {
-  padding-right: 10px !important;
-  padding-left: 10px !important;
-}
-
 xul|menulist > xul|*.menulist-label-box > xul|*.menulist-icon[src] {
   margin-inline-end: 5px;
 }
 
 xul|button[type="menu"] > xul|*.button-box > xul|*.button-menu-dropmarker {
   -moz-appearance: none;
   margin: 1px 0;
   margin-inline-start: 10px;
--- a/toolkit/themes/windows/global/button.css
+++ b/toolkit/themes/windows/global/button.css
@@ -48,27 +48,16 @@ button:-moz-focusring {
        the active, disabled, open or checked state, the appearance reverts back
        to the default background. */
     button:-moz-any([default="true"],:hover,:focus):not(:-moz-any(:active,[disabled="true"],[open="true"],[checked="true"])) {
       color: HighlightText;
     }
   }
 }
 
-/* .......... active/open/checked state .......... */
-
-@media (-moz-windows-classic) {
-  button:-moz-any(:hover:active,[open="true"],[checked="true"]):not([disabled="true"]) > .button-box {
-    padding-top: 3px;
-    padding-bottom: 2px;
-    padding-inline-start: 5px;
-    padding-inline-end: 4px;
-  }
-}
-
 /* .......... disabled state .......... */
 
 button[disabled="true"] {
   color: GrayText;
 }
 
 @media (-moz-windows-classic) {
   button[disabled="true"] {
--- a/toolkit/themes/windows/global/in-content/common.css
+++ b/toolkit/themes/windows/global/in-content/common.css
@@ -39,8 +39,13 @@ html|input[type="checkbox"]:-moz-focusri
      border: 2px dotted Highlight;
   }
 }
 
 html|button {
   /* XUL button min-width */
   min-width: 6.3em;
 }
+
+xul|button > xul|*.button-box {
+  padding-right: 0;
+  padding-left: 0;
+}