Bug 1528837 - Part 3: Rename ParserBase::tempPoolMark field to tempPoolMark_. r=Yoric
authorTooru Fujisawa <arai_a@mac.com>
Sun, 24 Feb 2019 03:26:08 +0000
changeset 518650 404e9820bc40c670422e2fd54affad2e5c371af0
parent 518649 886ae31b4f014d5e3a1e6da41bfe3b65469e26e8
child 518651 3bcda710f6bdc2c4cea19132d53b7190fe25f1b4
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersYoric
bugs1528837
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1528837 - Part 3: Rename ParserBase::tempPoolMark field to tempPoolMark_. r=Yoric Differential Revision: https://phabricator.services.mozilla.com/D20214
js/src/frontend/Parser.cpp
js/src/frontend/Parser.h
--- a/js/src/frontend/Parser.cpp
+++ b/js/src/frontend/Parser.cpp
@@ -153,31 +153,31 @@ ParserBase::ParserBase(JSContext* cx, Li
 #ifdef DEBUG
       checkOptionsCalled(false),
 #endif
       isUnexpectedEOF_(false),
       awaitHandling_(AwaitIsName),
       inParametersOfAsyncFunction_(false),
       parseGoal_(uint8_t(parseGoal)) {
   cx->frontendCollectionPool().addActiveCompilation();
-  tempPoolMark = alloc_.mark();
+  tempPoolMark_ = alloc_.mark();
 }
 
 bool ParserBase::checkOptions() {
 #ifdef DEBUG
   checkOptionsCalled = true;
 #endif
 
   return anyChars.checkOptions();
 }
 
 ParserBase::~ParserBase() {
   MOZ_ASSERT(checkOptionsCalled);
 
-  alloc_.release(tempPoolMark);
+  alloc_.release(tempPoolMark_);
 
   /*
    * The parser can allocate enormous amounts of memory for large functions.
    * Eagerly free the memory now (which otherwise won't be freed until the
    * next GC) to avoid unnecessary OOMs.
    */
   alloc_.freeAllIfHugeAndUnused();
 
--- a/js/src/frontend/Parser.h
+++ b/js/src/frontend/Parser.h
@@ -247,17 +247,17 @@ class MOZ_STACK_CLASS ParserBase : priva
                                         JS::AutoGCRooter* parser);
 
  public:
   JSContext* const cx_;
 
   LifoAlloc& alloc_;
 
   TokenStreamAnyChars anyChars;
-  LifoAlloc::Mark tempPoolMark;
+  LifoAlloc::Mark tempPoolMark_;
 
   /* list of parsed objects and BigInts for GC tracing */
   TraceListNode* traceListHead;
 
   /* innermost parse context (stack-allocated) */
   ParseContext* pc;
 
   // For tracking used names in this parsing session.