Bug 1359269 - Part 4: Update HTML spec idl files to use attributes on types; r=bzbarsky
authorManish Goregaokar <manishearth@gmail.com>
Sat, 02 Mar 2019 04:21:31 +0000
changeset 519957 3fccace0ea88508058cd36e13a9cff92ed7866a3
parent 519956 ee5af9ad9e458273f389e6952dd74ec81ab72036
child 519958 f4ec249fc52a26c94b9d04cad859faf32689267c
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbzbarsky
bugs1359269
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1359269 - Part 4: Update HTML spec idl files to use attributes on types; r=bzbarsky See https://github.com/whatwg/html/pull/2580 Depends on D19735 Differential Revision: https://phabricator.services.mozilla.com/D19736
dom/webidl/HTMLBodyElement.webidl
dom/webidl/HTMLElement.webidl
dom/webidl/HTMLInputElement.webidl
dom/webidl/HTMLTextAreaElement.webidl
--- a/dom/webidl/HTMLBodyElement.webidl
+++ b/dom/webidl/HTMLBodyElement.webidl
@@ -11,23 +11,23 @@
  * and create derivative works of this document.
  */
 
 [HTMLConstructor]
 interface HTMLBodyElement : HTMLElement {
 };
 
 partial interface HTMLBodyElement {
-  [CEReactions, TreatNullAs=EmptyString, SetterThrows]
-  attribute DOMString text;
-  [CEReactions, TreatNullAs=EmptyString, SetterThrows]
-  attribute DOMString link;
-  [CEReactions, TreatNullAs=EmptyString, SetterThrows]
-  attribute DOMString vLink;
-  [CEReactions, TreatNullAs=EmptyString, SetterThrows]
-  attribute DOMString aLink;
-  [CEReactions, TreatNullAs=EmptyString, SetterThrows]
-  attribute DOMString bgColor;
+  [CEReactions, SetterThrows]
+  attribute [TreatNullAs=EmptyString] DOMString text;
+  [CEReactions, SetterThrows]
+  attribute [TreatNullAs=EmptyString] DOMString link;
+  [CEReactions, SetterThrows]
+  attribute [TreatNullAs=EmptyString] DOMString vLink;
+  [CEReactions, SetterThrows]
+  attribute [TreatNullAs=EmptyString] DOMString aLink;
+  [CEReactions, SetterThrows]
+  attribute [TreatNullAs=EmptyString] DOMString bgColor;
   [CEReactions, SetterThrows]
   attribute DOMString background;
 };
 
 HTMLBodyElement implements WindowEventHandlers;
--- a/dom/webidl/HTMLElement.webidl
+++ b/dom/webidl/HTMLElement.webidl
@@ -20,18 +20,18 @@ interface HTMLElement : Element {
   [CEReactions]
            attribute DOMString lang;
   //         attribute boolean translate;
   [CEReactions, SetterThrows, Pure]
            attribute DOMString dir;
   [Constant]
   readonly attribute DOMStringMap dataset;
 
-  [CEReactions, GetterThrows, Pure, TreatNullAs=EmptyString]
-           attribute DOMString innerText;
+  [CEReactions, GetterThrows, Pure]
+           attribute [TreatNullAs=EmptyString] DOMString innerText;
 
   // user interaction
   [CEReactions, SetterThrows, Pure]
            attribute boolean hidden;
   [NeedsCallerType]
   void click();
   [CEReactions, SetterThrows, Pure]
            attribute long tabIndex;
--- a/dom/webidl/HTMLInputElement.webidl
+++ b/dom/webidl/HTMLInputElement.webidl
@@ -85,18 +85,18 @@ interface HTMLInputElement : HTMLElement
   [CEReactions, Pure, SetterNeedsSubjectPrincipal=NonSystem, SetterThrows]
            attribute DOMString src;
   [CEReactions, Pure, SetterThrows]
            attribute DOMString step;
   [CEReactions, Pure, SetterThrows]
            attribute DOMString type;
   [CEReactions, Pure, SetterThrows]
            attribute DOMString defaultValue;
-  [CEReactions, Pure, TreatNullAs=EmptyString, SetterThrows, NeedsCallerType]
-           attribute DOMString value;
+  [CEReactions, Pure, SetterThrows, NeedsCallerType]
+           attribute [TreatNullAs=EmptyString] DOMString value;
   [Throws, Func="HTMLInputElement::ValueAsDateEnabled"]
            attribute Date? valueAsDate;
   [Pure, SetterThrows]
            attribute unrestricted double valueAsNumber;
   [CEReactions, SetterThrows]
            attribute unsigned long width;
 
   [Throws]
--- a/dom/webidl/HTMLTextAreaElement.webidl
+++ b/dom/webidl/HTMLTextAreaElement.webidl
@@ -44,17 +44,17 @@ interface HTMLTextAreaElement : HTMLElem
            attribute unsigned long rows;
   [CEReactions, SetterThrows, Pure]
            attribute DOMString wrap;
 
   [Constant]
   readonly attribute DOMString type;
   [CEReactions, Throws, Pure]
            attribute DOMString defaultValue;
-  [CEReactions, SetterThrows, TreatNullAs=EmptyString] attribute DOMString value;
+  [CEReactions, SetterThrows] attribute [TreatNullAs=EmptyString] DOMString value;
   readonly attribute unsigned long textLength;
 
   readonly attribute boolean willValidate;
   readonly attribute ValidityState validity;
   [Throws]
   readonly attribute DOMString validationMessage;
   boolean checkValidity();
   boolean reportValidity();