Bug 1496224 - Followup to 1409570 - fix clang-tidy complaint r=bagder
authorNicholas Hurley <hurley@mozilla.com>
Thu, 04 Oct 2018 08:43:54 +0000
changeset 495365 3f4e7b1382fd2749c9fa7ae950f12e513c356c5b
parent 495364 e78d9996b1a44045dcf8a85722189a3db77033d3
child 495366 051b1c82dac88620fa79a48c6c269262c3888301
push id9984
push userffxbld-merge
push dateMon, 15 Oct 2018 21:07:35 +0000
treeherdermozilla-beta@183d27ea8570 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbagder
bugs1496224, 1409570
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1496224 - Followup to 1409570 - fix clang-tidy complaint r=bagder Differential Revision: https://phabricator.services.mozilla.com/D7652
netwerk/protocol/http/Http2Session.cpp
--- a/netwerk/protocol/http/Http2Session.cpp
+++ b/netwerk/protocol/http/Http2Session.cpp
@@ -3374,20 +3374,18 @@ Http2Session::WriteSegmentsAgain(nsAHttp
       if (streamToCleanup) {
         if (discardedPadding && !(streamToCleanup->StreamID() & 1)) {
           // Pushed streams are special on padding-only final data frames.
           // See bug 1409570 comments 6-8 for details.
           streamToCleanup->SetPushComplete();
           Http2Stream *pushSink = streamToCleanup->GetConsumerStream();
           if (pushSink) {
             bool enqueueSink = true;
-            for (auto iter = mPushesReadyForRead.begin();
-                 iter != mPushesReadyForRead.end();
-                 ++iter) {
-              if (*iter == pushSink) {
+            for (auto s : mPushesReadyForRead) {
+              if (s == pushSink) {
                 enqueueSink = false;
                 break;
               }
             }
             if (enqueueSink) {
               mPushesReadyForRead.Push(pushSink);
               // No use trying to clean up, it won't do anything, anyway
               streamToCleanup = nullptr;