Bug 1706496 - Fix proton checkbox styles for HCM. r=Gijs a=pascalc
authorEmilio Cobos Álvarez <emilio@crisal.io>
Wed, 21 Apr 2021 13:42:41 +0000
changeset 644229 3e840e6b7bbea1b06c229dcf3ebbf6804b0920b1
parent 644228 2e95aec994d905409eea6a722c1772fc582a8342
child 644230 aec56f6c79336fc6a29e2488162a43f3b5de79b1
push id15363
push userpchevrel@mozilla.com
push dateWed, 28 Apr 2021 16:14:10 +0000
treeherdermozilla-beta@aec56f6c7933 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs, pascalc
bugs1706496
milestone89.0
Bug 1706496 - Fix proton checkbox styles for HCM. r=Gijs a=pascalc Specifying a system color foreground with a non-system-color background is not good. Differential Revision: https://phabricator.services.mozilla.com/D112910
toolkit/themes/shared/checkbox.inc.css
--- a/toolkit/themes/shared/checkbox.inc.css
+++ b/toolkit/themes/shared/checkbox.inc.css
@@ -27,20 +27,20 @@ checkbox[disabled="true"] {
 }
 
 /* ::::: checkmark image ::::: */
 
 .checkbox-check {
   appearance: none;
   height: 16px;
   width: 16px;
-  border: 1px solid var(--checkbox-border-color, ThreeDDarkShadow);
+  color: var(--checkbox-border-color, ThreeDDarkShadow);
   background-color: var(--checkbox-unchecked-bgcolor, Field);
+  border: 1px solid currentColor;
   border-radius: 2px;
-  color: FieldText;
   margin-inline-end: 6px;
 }
 
 checkbox:not([disabled="true"]):hover > .checkbox-check {
   background-color: var(--checkbox-unchecked-hover-bgcolor, color-mix(in srgb, -moz-accent-color 4%, Field));
 }
 
 checkbox:not([disabled="true"]):hover:active > .checkbox-check {