Bug 1316211. P9 - remove SizeOf{Audio,Video}QueueInBytes() that has no callers. r=gerald
authorJW Wang <jwwang@mozilla.com>
Wed, 19 Jul 2017 15:08:27 +0800
changeset 418808 3e10f80060f91578aea2d954ef6601fe6f1bafa9
parent 418807 0bac6fca55b51a85ae4894a16dd8e328c966276a
child 418809 670f1c2a21307f3808e8bd27a9a3bf639f402a05
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgerald
bugs1316211
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1316211. P9 - remove SizeOf{Audio,Video}QueueInBytes() that has no callers. r=gerald MozReview-Commit-ID: A6TbGMdyDGQ
dom/media/MediaDecoderReader.cpp
dom/media/MediaDecoderReader.h
dom/media/MediaDecoderReaderWrapper.h
--- a/dom/media/MediaDecoderReader.cpp
+++ b/dom/media/MediaDecoderReader.cpp
@@ -58,26 +58,16 @@ MediaDecoderReader::Init()
 }
 
 MediaDecoderReader::~MediaDecoderReader()
 {
   MOZ_ASSERT(mShutdown);
   MOZ_COUNT_DTOR(MediaDecoderReader);
 }
 
-size_t MediaDecoderReader::SizeOfVideoQueueInBytes() const
-{
-  return 0;
-}
-
-size_t MediaDecoderReader::SizeOfAudioQueueInBytes() const
-{
-  return 0;
-}
-
 size_t MediaDecoderReader::SizeOfVideoQueueInFrames()
 {
   return 0;
 }
 
 size_t MediaDecoderReader::SizeOfAudioQueueInFrames()
 {
   return 0;
--- a/dom/media/MediaDecoderReader.h
+++ b/dom/media/MediaDecoderReader.h
@@ -190,24 +190,16 @@ public:
   }
 
   // The MediaDecoderStateMachine uses various heuristics that assume that
   // raw media data is arriving sequentially from a network channel. This
   // makes sense in the <video src="foo"> case, but not for more advanced use
   // cases like MSE.
   virtual bool UseBufferingHeuristics() const = 0;
 
-  // Returns the number of bytes of memory allocated by structures/frames in
-  // the video queue.
-  size_t SizeOfVideoQueueInBytes() const;
-
-  // Returns the number of bytes of memory allocated by structures/frames in
-  // the audio queue.
-  size_t SizeOfAudioQueueInBytes() const;
-
   virtual size_t SizeOfVideoQueueInFrames();
   virtual size_t SizeOfAudioQueueInFrames();
 
   // Called once new data has been cached by the MediaResource.
   // mBuffered should be recalculated and updated accordingly.
   virtual void NotifyDataArrived() = 0;
 
   AbstractCanonical<media::TimeIntervals>* CanonicalBuffered()
--- a/dom/media/MediaDecoderReaderWrapper.h
+++ b/dom/media/MediaDecoderReaderWrapper.h
@@ -59,22 +59,16 @@ public:
     return mReader->VideoIsHardwareAccelerated();
   }
   TimedMetadataEventSource& TimedMetadataEvent() {
     return mReader->TimedMetadataEvent();
   }
   MediaEventSource<void>& OnMediaNotSeekable() {
     return mReader->OnMediaNotSeekable();
   }
-  size_t SizeOfVideoQueueInBytes() const {
-    return mReader->SizeOfVideoQueueInBytes();
-  }
-  size_t SizeOfAudioQueueInBytes() const {
-    return mReader->SizeOfAudioQueueInBytes();
-  }
   size_t SizeOfAudioQueueInFrames() const {
     return mReader->SizeOfAudioQueueInFrames();
   }
   size_t SizeOfVideoQueueInFrames() const {
     return mReader->SizeOfVideoQueueInFrames();
   }
   void ReadUpdatedMetadata(MediaInfo* aInfo) {
     mReader->ReadUpdatedMetadata(aInfo);