Bug 1569772 - Release load group on main thread in win/nsIconChannel r=tnikkel a=RyanVM
authorJunior Hsu <juhsu@mozilla.com>
Mon, 29 Jul 2019 22:42:39 +0000
changeset 541685 3da66b493241eeb120d698a419f587963b0d802b
parent 541684 648715eb3f46e6264b04ad2372a47d257868f8b3
child 541686 52f871fd6b6183aaaee91348249b44fca573430f
push id11677
push userarchaeopteryx@coole-files.de
push dateThu, 01 Aug 2019 18:15:46 +0000
treeherdermozilla-beta@5db1324ed737 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstnikkel, RyanVM
bugs1569772
milestone69.0
Bug 1569772 - Release load group on main thread in win/nsIconChannel r=tnikkel a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D39795
image/decoders/icon/win/nsIconChannel.cpp
--- a/image/decoders/icon/win/nsIconChannel.cpp
+++ b/image/decoders/icon/win/nsIconChannel.cpp
@@ -165,16 +165,20 @@ nsIconChannel::IconSyncOpenTask::Run() {
 // nsIconChannel methods
 nsIconChannel::nsIconChannel() {}
 
 nsIconChannel::~nsIconChannel() {
   if (mLoadInfo) {
     NS_ReleaseOnMainThreadSystemGroup("nsIconChannel::mLoadInfo",
                                       mLoadInfo.forget());
   }
+  if (mLoadGroup) {
+    NS_ReleaseOnMainThreadSystemGroup("nsIconChannel::mLoadGroup",
+                                      mLoadGroup.forget());
+  }
 }
 
 NS_IMPL_ISUPPORTS(nsIconChannel, nsIChannel, nsIRequest, nsIRequestObserver,
                   nsIStreamListener)
 
 nsresult nsIconChannel::Init(nsIURI* uri) {
   NS_ASSERTION(uri, "no uri");
   mUrl = uri;