Bug 1657312 - Don't round clip rect. r=mstange, a=jcristau
authorMatt Woodrow <mwoodrow@mozilla.com>
Fri, 14 Aug 2020 06:16:52 +0000
changeset 610516 3d6ac877c7f3dd0e99d470565f320315008bf472
parent 610515 c4132bb4ff67a111011c7775280c4cdaedb22f21
child 610517 eeffd540a67cd46cd2f97c01284b123aaca27d88
push id13615
push userjcristau@mozilla.com
push dateThu, 27 Aug 2020 13:50:38 +0000
treeherdermozilla-beta@c4a51bbb48ce [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstange, jcristau
bugs1657312
milestone81.0
Bug 1657312 - Don't round clip rect. r=mstange, a=jcristau Depends on D86088 Differential Revision: https://phabricator.services.mozilla.com/D87023
gfx/webrender_bindings/DCLayerTree.cpp
--- a/gfx/webrender_bindings/DCLayerTree.cpp
+++ b/gfx/webrender_bindings/DCLayerTree.cpp
@@ -367,17 +367,16 @@ void DCLayerTree::AddSurface(wr::NativeS
   // DirectComposition does have an option for pre-transform clipping, if you
   // create an explicit IDCompositionEffectGroup object and set a 3D transform
   // on that. I suspect that will perform worse though, so we should only do
   // that for complex transforms (which are never provided right now).
   MOZ_ASSERT(transform.IsRectilinear());
   gfx::Rect clip = transform.Inverse().TransformBounds(
       gfx::Rect(aClipRect.origin.x, aClipRect.origin.y, aClipRect.size.width,
                 aClipRect.size.height));
-  clip.Round();
   // Set the clip rect - converting from world space to the pre-offset space
   // that DC requires for rectangle clips.
   visual->SetClip(D2DRect(clip));
 
   // TODO: The input matrix is a 4x4, but we only support a 3x2 at
   // the D3D API level (unless we QI to IDCompositionVisual3, which might
   // not be available?).
   // Should we assert here, or restrict at the WR API level.