Bug 1386776 - Beta shouldn't schedule nightly l10n on-push. r=Callek, a=release
authorJohan Lorenzo <jlorenzo@mozilla.com>
Thu, 03 Aug 2017 14:24:00 +0200
changeset 420979 3d66f6f6a84773458df80d8e09972726169dd4b5
parent 420978 f9b4b766ab8ea75ac81dbb359af6087f3880295a
child 420980 68b791c2971af37c17ed9b1903302fb58f3be938
push id7571
push userryanvm@gmail.com
push dateThu, 03 Aug 2017 21:50:45 +0000
treeherdermozilla-beta@68b791c2971a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersCallek, release
bugs1386776
milestone56.0
Bug 1386776 - Beta shouldn't schedule nightly l10n on-push. r=Callek, a=release MozReview-Commit-ID: 98jzxVfoQEo
taskcluster/taskgraph/target_tasks.py
--- a/taskcluster/taskgraph/target_tasks.py
+++ b/taskcluster/taskgraph/target_tasks.py
@@ -264,22 +264,31 @@ def target_tasks_mozilla_beta(full_task_
                         'android-x86-nightly'):
             return False
         if platform in ('linux64', 'linux'):
             if task.attributes['build_type'] == 'opt' and \
                task.attributes.get('unittest_suite') != 'talos':
                 return False
         # skip l10n, beetmover, balrog
         if task.kind in [
-            'balrog', 'beetmover', 'beetmover-checksums', 'beetmover-l10n',
-            'checksums-signing', 'nightly-l10n', 'nightly-l10n-signing',
-            'push-apk', 'push-apk-breakpoint', 'beetmover-repackage',
-            'beetmover-repackage-signing',
+            'balrog',
+            'beetmover', 'beetmover-checksums', 'beetmover-l10n',
+            'beetmover-repackage', 'beetmover-repackage-signing',
+            'checksums-signing',
+            'nightly-l10n', 'nightly-l10n-signing',
+            'push-apk', 'push-apk-breakpoint',
+            'repackage-l10n',
         ]:
             return False
+
+        # No l10n repacks per push. They may be triggered by kinds which depend
+        # on l10n builds/repacks. For instance: "repackage-signing"
+        if task.attributes.get('locale', '') != '':
+            return False
+
         return True
 
     return [l for l, t in full_task_graph.tasks.iteritems() if filter(t)]
 
 
 @_target_task('mozilla_release_tasks')
 def target_tasks_mozilla_release(full_task_graph, parameters):
     """Select the set of tasks required for a promotable beta or release build