Bug 1534013 - Only run profiler's mainthreadio feature test on nightly; r=canaltinova
authorGreg Tatum <gtatum@mozilla.com>
Mon, 11 Mar 2019 15:29:25 +0000
changeset 521413 3cb869d04118
parent 521412 bac8eff6ce0d
child 521414 daaee58201c2
push id10866
push usernerli@mozilla.com
push dateTue, 12 Mar 2019 18:59:09 +0000
treeherdermozilla-beta@445c24a51727 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscanaltinova
bugs1534013
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1534013 - Only run profiler's mainthreadio feature test on nightly; r=canaltinova I initially forgot that this test should only be run on nightly, as the interposer is disabled on release and beta. Differential Revision: https://phabricator.services.mozilla.com/D22982
tools/profiler/tests/test_feature_mainthreadio.js
tools/profiler/tests/xpcshell.ini
--- a/tools/profiler/tests/test_feature_mainthreadio.js
+++ b/tools/profiler/tests/test_feature_mainthreadio.js
@@ -1,16 +1,19 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 const {FileUtils} = ChromeUtils.import("resource://gre/modules/FileUtils.jsm");
 
 /**
  * Test that the IOInterposer is working correctly to capture main thread IO.
+ *
+ * This test should not run on release or beta, as the IOInterposer is wrapped in
+ * an ifdef.
  */
 add_task(async () => {
   if (!AppConstants.MOZ_GECKO_PROFILER) {
     return;
   }
 
   // Let the test harness settle, in order to avoid extraneous FileIO operations. This
   // helps avoid false positives that we are actually triggering FileIO.
--- a/tools/profiler/tests/xpcshell.ini
+++ b/tools/profiler/tests/xpcshell.ini
@@ -11,8 +11,9 @@ skip-if = true
 [test_pause.js]
 [test_enterjit_osr.js]
 [test_enterjit_osr_disabling.js]
 skip-if = !debug
 [test_enterjit_osr_enabling.js]
 skip-if = !debug
 [test_asm.js]
 [test_feature_mainthreadio.js]
+skip-if = release_or_beta # The IOInterposer is in an ifdef.