Bug 1515746 - [flake8] Upgrade flake8 and dependencies, r=egao
authorAndrew Halberstadt <ahalberstadt@mozilla.com>
Thu, 07 Feb 2019 20:16:45 +0000
changeset 515562 3c7c50fba28399ae0d1a3812e5088cde55aacd8e
parent 515561 ba9e0f7f49a3b4844122676de241dc2ce6671e22
child 515563 f96c1460ffc09ef61bf3e2c93bfda21cdb86fb2f
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersegao
bugs1515746
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1515746 - [flake8] Upgrade flake8 and dependencies, r=egao This bumps flake8 to version 3.7.5. This also ignores the new lint rules that were added in the new versions. These rules are de-marked via comment so we know that they should be enabled at some point (as opposed to the other rules that are (presumably) ignored intentionally. Differential Revision: https://phabricator.services.mozilla.com/D18353
.flake8
ipc/ipdl/.flake8
security/manager/.flake8
testing/mozharness/configs/.flake8
tools/lint/python/flake8_requirements.txt
--- a/.flake8
+++ b/.flake8
@@ -1,26 +1,35 @@
 [flake8]
-# See http://pep8.readthedocs.io/en/latest/intro.html#configuration
-ignore = E121, E123, E126, E129, E133, E226, E241, E242, E704, W503, E402, E741
 max-line-length = 99
 exclude =
+    build/build-infer/build-infer.py,
+    build/moz.configure/*.configure,
+    build/pymake/,
     browser/extensions/mortar/ppapi/,
     browser/moz.configure,
-    build/moz.configure/*.configure,
-    build/pymake/,
     dom/canvas/test/webgl-conf/checkout/closure-library/,
     editor/libeditor/tests/browserscope/,
     intl/icu/,
     ipc/chromium/src/third_party/,
+    js/*.configure,
     gfx/angle/,
     gfx/harfbuzz,
     glx/skia/,
-    js/*.configure,
     memory/moz.configure,
     mobile/android/*.configure,
     node_modules,
     security/nss/,
     testing/mochitest/pywebsocket,
     tools/lint/test/files,
-    build/build-infer/build-infer.py,
-    tools/infer/test/*.configure,    tools/infer/test/*.configure,
+    tools/infer/test/*.configure,
     tools/crashreporter/*.configure,
+
+# See:
+#   - http://flake8.pycqa.org/en/latest/user/error-codes.html
+#   - http://pep8.readthedocs.io/en/latest/intro.html#configuration
+ignore =
+    # These should be triaged and either fixed or moved to the list below.
+    F632, F633, F811, E117, W504, W605, W606,
+    # These are intentionally disabled (not necessarily for good reason).
+    #   F723: syntax error in type comment
+    #       text contains quotes which breaks our custom JSON formatter
+    F723, E121, E123, E126, E129, E133, E226, E241, E242, E402, E704, E741, W503,
--- a/ipc/ipdl/.flake8
+++ b/ipc/ipdl/.flake8
@@ -1,5 +1,5 @@
 [flake8]
 # See http://pep8.readthedocs.io/en/latest/intro.html#configuration
-ignore = E121, E123, E126, E129, E133, E226, E241, E242, E704, W503, E402, E741, F405, F403
+ignore = E121, E123, E126, E129, E133, E226, E241, E242, E704, W503, E402, E741, F405, F403, W504
 max-line-length = 99
 
--- a/security/manager/.flake8
+++ b/security/manager/.flake8
@@ -1,14 +1,14 @@
 [flake8]
 # E128: continuation line under-indented for visual indent.
 #       Best visual indent typically determined based on context.
 # E261: at least two spaces before inline comment.
 #       Not PSM style.
 # E302: expected 2 blank lines, found 1.
 #       Not really PSM style.
-ignore = E128,E261,E302
+ignore = E128,E261,E302,W605,W504
 
 # PSM style is to stick close to 80 chars, but 4 space indentation means we
 # sometimes need more space.
 max-line-length = 100
 
 filename = *.py
--- a/testing/mozharness/configs/.flake8
+++ b/testing/mozharness/configs/.flake8
@@ -1,12 +1,12 @@
 [flake8]
 ignore =
     # From root
-    E121, E123, E126, E129, E133, E226, E241, E242, E704, W503, E402,
+    E121, E123, E126, E129, E133, E226, E241, E242, E704, W503, E402, W605, W504,
     # The following errors should be fixed eventually
     # line too long
     E501,
     # at least two spaces before inline comment
     E261,
     # continuation line under-indented for visual indent
     E128,
     # whitespace before ':'
--- a/tools/lint/python/flake8_requirements.txt
+++ b/tools/lint/python/flake8_requirements.txt
@@ -1,24 +1,36 @@
-flake8==3.5.0 \
-    --hash=sha256:c7841163e2b576d435799169b78703ad6ac1bbb0f199994fc05f700b2a90ea37 \
-    --hash=sha256:7253265f7abd8b313e3892944044a365e3f4ac3fcdcfb4298f55ee9ddf188ba0
+flake8==3.7.5 \
+    --hash=sha256:c3ba1e130c813191db95c431a18cb4d20a468e98af7a77e2181b68574481ad36 \
+    --hash=sha256:fd9ddf503110bf3d8b1d270e8c673aab29ccb3dd6abf29bae1f54e5116ab4a91
 mccabe==0.6.1 \
     --hash=sha256:ab8a6258860da4b6677da4bd2fe5dc2c659cff31b3ee4f7f5d64e79735b80d42 \
     --hash=sha256:dd8d182285a0fe56bace7f45b5e7d1a6ebcbf524e8f3bd87eb0f125271b8831f
-pyflakes==1.5.0 \
-    --hash=sha256:cc5eadfb38041f8366128786b4ca12700ed05bbf1403d808e89d57d67a3875a7 \
-    --hash=sha256:aa0d4dff45c0cc2214ba158d29280f8fa1129f3e87858ef825930845146337f4
-pycodestyle==2.3.1 \
-    --hash=sha256:6c4245ade1edfad79c3446fadfc96b0de2759662dc29d07d80a6f27ad1ca6ba9 \
-    --hash=sha256:682256a5b318149ca0d2a9185d365d8864a768a28db66a84a2ea946bcc426766
+pyflakes==2.1.0 \
+    --hash=sha256:f277f9ca3e55de669fba45b7393a1449009cff5a37d1af10ebb76c52765269cd \
+    --hash=sha256:5e8c00e30c464c99e0b501dc160b13a14af7f27d4dffb529c556e30a159e231d
+pycodestyle==2.5.0 \
+    --hash=sha256:95a2219d12372f05704562a14ec30bc76b05a5b297b21a5dfe3f6fac3491ae56 \
+    --hash=sha256:e40a936c9a450ad81df37f549d676d127b1b66000a6c500caa2b085bc0ca976c
 enum34==1.1.6 \
     --hash=sha256:6bd0f6ad48ec2aa117d3d141940d484deccda84d4fcd884f5c3d93c23ecd8c79 \
     --hash=sha256:644837f692e5f550741432dd3f223bbb9852018674981b1664e5dc339387588a \
     --hash=sha256:8ad8c4783bf61ded74527bffb48ed9b54166685e4230386a9ed9b1279e2df5b1 \
     --hash=sha256:2d81cbbe0e73112bdfe6ef8576f2238f2ba27dd0d55752a776c41d38b7da2850
-configparser==3.5.0 \
-    --hash=sha256:5308b47021bc2340965c371f0f058cc6971a04502638d4244225c49d80db273a
-setuptools==38.5.1 \
-    --hash=sha256:7ffe771abfae419fd104f93400b61c935b5af10bfe4dfeec7a1bd495694eea35 \
-    --hash=sha256:6425484c08e99a98a42209c25c3d325f749230b55284d66192784f941a7e6628
-autopep8==1.3.5 \
-    --hash=sha256:2284d4ae2052fedb9f466c09728e30d2e231cfded5ffd7b1a20c34123fdc4ba4
+configparser==3.7.1 \
+    --hash=sha256:c114ff90ee2e762db972fa205f02491b1f5cf3ff950decd8542c62970c9bedac \
+    --hash=sha256:df28e045fbff307a28795b18df6ac8662be3219435560ddb068c283afab1ea7a \
+    --hash=sha256:5bd5fa2a491dc3cfe920a3f2a107510d65eceae10e9c6e547b90261a4710df32
+setuptools==40.7.1 \
+    --hash=sha256:252520b7969fb4f2fcaf08c014b2891041d56f31180ec0d581297a28597205ff \
+    --hash=sha256:5926bbea397d0fcec2f7946f1691f5820ef0234247b2d5fa83d30cc216d613ec
+autopep8==1.4.3 \
+    --hash=sha256:33d2b5325b7e1afb4240814fe982eea3a92ebea712869bfd08b3c0393404248c
+entrypoints==0.3 \
+    --hash=sha256:589f874b313739ad35be6e0cd7efde2a4e9b6fea91edcc34e58ecbb8dbe56d19 \
+    --hash=sha256:c70dd71abe5a8c85e55e12c19bd91ccfeec11a6e99044204511f9ed547d48451
+typing==3.6.6 \
+    --hash=sha256:a4c8473ce11a65999c8f59cb093e70686b6c84c98df58c1dae9b3b196089858a \
+    --hash=sha256:57dcf675a99b74d64dacf6fba08fb17cf7e3d5fdff53d4a30ea2a5e7e52543d4 \
+    --hash=sha256:4027c5f6127a6267a435201981ba156de91ad0d1d98e9ddc2aa173453453492d
+functools32==3.2.3-2 \
+    --hash=sha256:f6253dfbe0538ad2e387bd8fdfd9293c925d63553f5813c4e587745416501e6d \
+    --hash=sha256:89d824aa6c358c421a234d7f9ee0bd75933a67c29588ce50aaa3acdf4d403fa0