Bug 1549667 - [mips] skip tests which need --spectre-XXX on. r=jandem
authorYu Yin <yuyin-hf@loongson.cn>
Fri, 10 May 2019 10:04:16 +0300
changeset 532174 3c7878ad3840fbf8c2aee6df01f24e8e650f5fc3
parent 532173 e8aa696bdf817cf7b01be648d47f280ab54f8382
child 532175 2b44ebc6ee1717f138d801513af4c2e6e50c4087
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjandem
bugs1549667
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1549667 - [mips] skip tests which need --spectre-XXX on. r=jandem Reviewers: jandem, lth Reviewed By: jandem Subscribers: jandem Bug #: 1549667 Differential Revision: https://phabricator.services.mozilla.com/D30172
js/src/builtin/TestingFunctions.cpp
js/src/jit-test/tests/ion/bug1433496.js
--- a/js/src/builtin/TestingFunctions.cpp
+++ b/js/src/builtin/TestingFunctions.cpp
@@ -250,16 +250,34 @@ static bool GetBuildConfiguration(JSCont
   value = BooleanValue(true);
 #else
   value = BooleanValue(false);
 #endif
   if (!JS_SetProperty(cx, info, "arm64-simulator", value)) {
     return false;
   }
 
+#ifdef JS_CODEGEN_MIPS32
+  value = BooleanValue(true);
+#else
+  value = BooleanValue(false);
+#endif
+  if (!JS_SetProperty(cx, info, "mips32", value)) {
+    return false;
+  }
+
+#ifdef JS_CODEGEN_MIPS64
+  value = BooleanValue(true);
+#else
+  value = BooleanValue(false);
+#endif
+  if (!JS_SetProperty(cx, info, "mips64", value)) {
+    return false;
+  }
+
 #ifdef JS_SIMULATOR_MIPS32
   value = BooleanValue(true);
 #else
   value = BooleanValue(false);
 #endif
   if (!JS_SetProperty(cx, info, "mips32-simulator", value)) {
     return false;
   }
--- a/js/src/jit-test/tests/ion/bug1433496.js
+++ b/js/src/jit-test/tests/ion/bug1433496.js
@@ -1,6 +1,6 @@
-// |jit-test| --spectre-mitigations=on
+// |jit-test| --spectre-mitigations=on; skip-if: getBuildConfiguration()['mips32'] || getBuildConfiguration()['mips64']
 function f() {
     return arguments[arguments.length];
 }
 for (var i = 0; i < 10; i++)
     assertEq(f(), undefined);