Bug 1533725 - Enable column breakpoints by default. r=loganfsmyth
authorJason Laster <jlaster@mozilla.com>
Sat, 09 Mar 2019 17:06:29 +0000
changeset 521267 3c4b55694127237c3dd740d5ed055959c4d783fe
parent 521266 e0c39e6d8d2c77b51118d388515c37628277f2a6
child 521268 91d0c9066fd139285e025b0b87a70f61823281af
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersloganfsmyth
bugs1533725
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1533725 - Enable column breakpoints by default. r=loganfsmyth Differential Revision: https://phabricator.services.mozilla.com/D22697
devtools/client/debugger/new/src/components/SecondaryPanes/Breakpoints/tests/__snapshots__/Breakpoint.spec.js.snap
devtools/client/debugger/new/src/utils/prefs.js
devtools/client/preferences/debugger.js
--- a/devtools/client/debugger/new/src/components/SecondaryPanes/Breakpoints/tests/__snapshots__/Breakpoint.spec.js.snap
+++ b/devtools/client/debugger/new/src/components/SecondaryPanes/Breakpoints/tests/__snapshots__/Breakpoint.spec.js.snap
@@ -27,17 +27,17 @@ exports[`Breakpoint disabled 1`] = `
     />
   </label>
   <div
     className="breakpoint-line-close"
   >
     <div
       className="breakpoint-line devtools-monospace"
     >
-      53
+      53:73
     </div>
     <CloseButton
       handleClick={[Function]}
       tooltip="Remove breakpoint"
     />
   </div>
 </div>
 `;
@@ -69,17 +69,17 @@ exports[`Breakpoint paused at a differen
     />
   </label>
   <div
     className="breakpoint-line-close"
   >
     <div
       className="breakpoint-line devtools-monospace"
     >
-      53
+      53:73
     </div>
     <CloseButton
       handleClick={[Function]}
       tooltip="Remove breakpoint"
     />
   </div>
 </div>
 `;
@@ -111,17 +111,17 @@ exports[`Breakpoint paused at a generate
     />
   </label>
   <div
     className="breakpoint-line-close"
   >
     <div
       className="breakpoint-line devtools-monospace"
     >
-      53
+      53:73
     </div>
     <CloseButton
       handleClick={[Function]}
       tooltip="Remove breakpoint"
     />
   </div>
 </div>
 `;
@@ -153,17 +153,17 @@ exports[`Breakpoint paused at an origina
     />
   </label>
   <div
     className="breakpoint-line-close"
   >
     <div
       className="breakpoint-line devtools-monospace"
     >
-      5
+      5:7
     </div>
     <CloseButton
       handleClick={[Function]}
       tooltip="Remove breakpoint"
     />
   </div>
 </div>
 `;
@@ -195,17 +195,17 @@ exports[`Breakpoint simple 1`] = `
     />
   </label>
   <div
     className="breakpoint-line-close"
   >
     <div
       className="breakpoint-line devtools-monospace"
     >
-      53
+      53:73
     </div>
     <CloseButton
       handleClick={[Function]}
       tooltip="Remove breakpoint"
     />
   </div>
 </div>
 `;
--- a/devtools/client/debugger/new/src/utils/prefs.js
+++ b/devtools/client/debugger/new/src/utils/prefs.js
@@ -49,17 +49,17 @@ if (isDevelopment()) {
   pref("devtools.debugger.features.async-stepping", true);
   pref("devtools.debugger.features.wasm", true);
   pref("devtools.debugger.features.shortcuts", true);
   pref("devtools.debugger.features.root", true);
   pref("devtools.debugger.features.map-scopes", true);
   pref("devtools.debugger.features.remove-command-bar-options", true);
   pref("devtools.debugger.features.code-folding", false);
   pref("devtools.debugger.features.outline", true);
-  pref("devtools.debugger.features.column-breakpoints", false);
+  pref("devtools.debugger.features.column-breakpoints", true);
   pref("devtools.debugger.features.skip-pausing", true);
   pref("devtools.debugger.features.component-pane", false);
   pref("devtools.debugger.features.autocomplete-expressions", false);
   pref("devtools.debugger.features.map-expression-bindings", true);
   pref("devtools.debugger.features.map-await-expression", true);
   pref("devtools.debugger.features.xhr-breakpoints", true);
   pref("devtools.debugger.features.original-blackbox", true);
   pref("devtools.debugger.features.windowless-workers", true);
--- a/devtools/client/preferences/debugger.js
+++ b/devtools/client/preferences/debugger.js
@@ -52,17 +52,17 @@ pref("devtools.debugger.file-search-rege
 pref("devtools.debugger.project-directory-root", "");
 pref("devtools.debugger.skip-pausing", false);
 pref("devtools.debugger.logging", false);
 pref("devtools.debugger.map-scopes-enabled", false);
 
 pref("devtools.debugger.features.wasm", true);
 pref("devtools.debugger.features.shortcuts", true);
 pref("devtools.debugger.features.root", true);
-pref("devtools.debugger.features.column-breakpoints", false);
+pref("devtools.debugger.features.column-breakpoints", true);
 pref("devtools.debugger.features.chrome-scopes", false);
 pref("devtools.debugger.features.map-scopes", true);
 pref("devtools.debugger.features.remove-command-bar-options", false);
 pref("devtools.debugger.features.workers", true);
 pref("devtools.debugger.features.code-coverage", false);
 pref("devtools.debugger.features.code-folding", false);
 pref("devtools.debugger.features.outline", true);
 pref("devtools.debugger.features.component-pane", false);