Bug 1499208 - Use task name to determine gpu-ness of backfilled tasks; r=jmaher
authorGeoff Brown <gbrown@mozilla.com>
Tue, 16 Oct 2018 16:13:33 -0600
changeset 497337 3ad5c00150c8b15ce6698b1d825a04ed7faf7c10
parent 497315 ffba3ac1d2bb4064bc7eeb398ed119cb0a28210e
child 497338 52a35a1526e787da657af59fb35bb5c53594744a
push id9996
push userarchaeopteryx@coole-files.de
push dateThu, 18 Oct 2018 18:37:15 +0000
treeherdermozilla-beta@8efe26839243 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs1499208
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1499208 - Use task name to determine gpu-ness of backfilled tasks; r=jmaher Existing mozharness per_test_base logic determines gpu-ness in the same way: If the requested test is in a manifest for a suite named 'reftest', '*gpu', or 'webgl*', then the test should only be run in a gpu-enabled test-verify and will be skipped otherwise. With this change, backfill will select between TV/TVg based on the name of the originating task, applying the same rule. So, to backfill a test in TV, select the backfill action from a non-gpu task; to backfill a test in TVg, select the backfill action from a gpu task.
taskcluster/taskgraph/actions/backfill.py
--- a/taskcluster/taskgraph/actions/backfill.py
+++ b/taskcluster/taskgraph/actions/backfill.py
@@ -113,27 +113,24 @@ def backfill_action(parameters, graph_co
                 if task.label != label:
                     return task
                 if input.get('addGeckoProfile'):
                     cmd = task.task['payload']['command']
                     task.task['payload']['command'] = add_args_to_command(cmd, ['--geckoProfile'])
                     task.task['extra']['treeherder']['symbol'] += '-p'
 
                 if input.get('testPath', ''):
-                    tp = input.get('testPath', '')
                     is_wpttest = 'web-platform' in task.task['metadata']['name']
                     is_android = 'android' in task.task['metadata']['name']
                     gpu_required = False
-                    # TODO: this has a high chance of getting out of date
                     if (not is_wpttest) and \
                        ('gpu' in task.task['metadata']['name'] or
                         'webgl' in task.task['metadata']['name'] or
-                        'canvas' in tp or
-                        'gfx/tests' in tp or
-                        ('reftest' in tp and 'jsreftest' not in tp)):
+                        ('reftest' in task.task['metadata']['name'] and
+                         'jsreftest' not in task.task['metadata']['name'])):
                         gpu_required = True
 
                     # Create new cmd that runs a test-verify type job
                     preamble_length = 3
                     verify_args = ['--e10s',
                                    '--verify',
                                    '--total-chunk=1',
                                    '--this-chunk=1']