Bug 1533588 - Bookmark confirmation hint panel is missing "Saved to Library!" text after landing patch from bug #1528955 r=dao
authorRicky Rosario <rickyrosario@gmail.com>
Wed, 13 Mar 2019 08:16:27 +0000
changeset 521697 3a83232643982f63b5e7c054c67507c411b24d30
parent 521696 916f90879f389f7b64b460506acce8f2f1f981bf
child 521698 4be0480f48d3bede45eb0f18479dc7cd2d686aa8
push id10867
push userdvarga@mozilla.com
push dateThu, 14 Mar 2019 15:20:45 +0000
treeherdermozilla-beta@abad13547875 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1533588, 1528955
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1533588 - Bookmark confirmation hint panel is missing "Saved to Library!" text after landing patch from bug #1528955 r=dao MozReview-Commit-ID: Ks6TAsIpHFz Differential Revision: https://phabricator.services.mozilla.com/D22991
browser/base/content/browser.js
browser/base/content/browser.xul
browser/themes/shared/customizableui/panelUI.inc.css
--- a/browser/base/content/browser.js
+++ b/browser/base/content/browser.js
@@ -8297,24 +8297,24 @@ var ConfirmationHint = {
     }
 
     if (options.hideArrow) {
       this._panel.setAttribute("hidearrow", "true");
     }
 
     // The timeout value used here allows the panel to stay open for
     // 1.5s second after the text transition (duration=120ms) has finished.
-    // If there is a description, we show for 4s and there is no text transition.
-    const DURATION = options.showDescription ? 4000 : 1500 + 120;
+    // If there is a description, we show for 4s after the text transition.
+    const DURATION = options.showDescription ? 4000 : 1500;
     this._panel.addEventListener("popupshown", () => {
       this._animationBox.setAttribute("animate", "true");
 
       setTimeout(() => {
         this._panel.hidePopup(true);
-      }, DURATION);
+      }, DURATION + 120);
     }, {once: true});
 
     this._panel.addEventListener("popuphidden", () => {
       this._panel.removeAttribute("hidearrow");
       this._animationBox.removeAttribute("animate");
     }, {once: true});
 
     this._panel.hidden = false;
--- a/browser/base/content/browser.xul
+++ b/browser/base/content/browser.xul
@@ -567,17 +567,17 @@
            hidden="true"
            flip="slide"
            position="bottomcenter topright"
            tabspecific="true"
            noautofocus="true">
       <hbox id="confirmation-hint-checkmark-animation-container">
        <image id="confirmation-hint-checkmark-image"/>
       </hbox>
-      <vbox>
+      <vbox id="confirmation-hint-message-container">
        <label id="confirmation-hint-message"/>
        <label id="confirmation-hint-description"/>
       </vbox>
     </panel>
 
     <menupopup id="pageActionContextMenu"
                onpopupshowing="BrowserPageActions.onContextMenuShowing(event, this);">
       <menuitem class="pageActionContextMenuItem builtInUnpinned"
--- a/browser/themes/shared/customizableui/panelUI.inc.css
+++ b/browser/themes/shared/customizableui/panelUI.inc.css
@@ -298,24 +298,24 @@ panel[photon] > .panel-arrowcontainer > 
   margin-inline-end: 0;
 }
 
 #confirmation-hint.with-description #confirmation-hint-message {
   font-size: 1.2em;
   font-weight: 600;
 }
 
-#confirmation-hint:not(.with-description) #confirmation-hint-message {
+#confirmation-hint-message-container {
   transform: scale(.8);
   opacity: 0;
   transition: transform 120ms cubic-bezier(.25,1.27,.35,1.18),
               opacity 60ms linear;
 }
 
-#confirmation-hint-checkmark-animation-container[animate] + #confirmation-hint-message {
+#confirmation-hint-checkmark-animation-container[animate] + #confirmation-hint-message-container {
   transform: scale(1);
   opacity: 1;
 }
 
 .cui-widget-panel[viewId^=PanelUI-webext-] > .panel-arrowcontainer > .panel-arrowcontent {
   padding: 0;
 }