Bug 1428917 - Remove broken RTL support for inspector breadcrumbs in RTL locales. r=gl, a=RyanVM DEVEDITION_69_0b14_BUILD1 DEVEDITION_69_0b14_RELEASE FIREFOX_69_0b14_BUILD1 FIREFOX_69_0b14_RELEASE
authorItiel <itiel_yn8@walla.com>
Wed, 14 Aug 2019 14:58:25 +0000
changeset 541953 3a3ff2f2324cea34a7f2db4ecf865e6ffd8ebbc5
parent 541952 151bfae582afadf93c61e55e1fd4f980a716756f
child 541954 11d75688957876919c309276aa8033e6e5320ffb
push id11793
push userryanvm@gmail.com
push dateThu, 15 Aug 2019 16:39:25 +0000
treeherdermozilla-beta@3a3ff2f2324c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgl, RyanVM
bugs1428917
milestone69.0
Bug 1428917 - Remove broken RTL support for inspector breadcrumbs in RTL locales. r=gl, a=RyanVM Since the 2 code panels above are LTR and in english characters only, it doesn't make sense to break the flow and make the bottom part RTL, so this removes RTL support altogether and forces LTR on html-arrowscrollbox-inner. Differential Revision: https://phabricator.services.mozilla.com/D41287
devtools/client/themes/breadcrumbs.css
devtools/client/themes/inspector.css
--- a/devtools/client/themes/breadcrumbs.css
+++ b/devtools/client/themes/breadcrumbs.css
@@ -109,32 +109,16 @@
   border-width: 0;
 }
 
 .breadcrumbs-widget-item:first-child::before {
   /* The first crumb does not need any separator before itself */
   content: unset;
 }
 
-.breadcrumbs-widget-item:dir(rtl)::before {
-  transform: scaleX(-1);
-}
-
-/* RTL support: move the images that were on the left to the right,
- * and move images that were on the right to the left.
- */
-.breadcrumbs-widget-item:dir(rtl) {
-  padding: 0 20px 0 8px;
-}
-
-.breadcrumbs-widget-item:dir(rtl),
-.breadcrumbs-widget-item[checked] + .breadcrumbs-widget-item:dir(rtl) {
-  background-position: center right;
-}
-
 .breadcrumbs-widget-item:not(:first-child)::before {
   content: url(chrome://devtools/skin/images/breadcrumbs-divider.svg);
   background: none;
   position: relative;
   left: -3px;
   margin: 0 4px 0 -1px;
   top: -1px;
 }
--- a/devtools/client/themes/inspector.css
+++ b/devtools/client/themes/inspector.css
@@ -142,16 +142,17 @@ window {
   display: flex;
   align-items: center;
 }
 
 #inspector-breadcrumbs .html-arrowscrollbox-inner {
   flex: 1;
   display: flex;
   overflow: hidden;
+  direction: ltr;
 }
 
 #inspector-breadcrumbs .breadcrumbs-widget-item {
   white-space: nowrap;
   flex-shrink: 0;
 }
 
 #inspector-rules-container,