Bug 1456522 - Stop making the tabs toolbar transparent when there's no title bar behind it, i.e. in fullscreen mode. r=stransky, a=RyanVM on a CLOSED TREE FIREFOX_60b_RELBRANCH
authorDão Gottwald <dao@mozilla.com>
Tue, 24 Apr 2018 17:58:53 +0200
branchFIREFOX_60b_RELBRANCH
changeset 469605 3a1aae811a582d2f78f893a4626e125e685caef8
parent 469604 4bdbddf15a016877ba545646b97f008026ac6aa2
child 469800 b28d01fdafa5e2c0d39dc389574bd7d6e4a0ffac
push id9173
push userryanvm@gmail.com
push dateSat, 28 Apr 2018 16:43:38 +0000
treeherdermozilla-beta@3a1aae811a58 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersstransky, RyanVM
bugs1456522
milestone60.0
Bug 1456522 - Stop making the tabs toolbar transparent when there's no title bar behind it, i.e. in fullscreen mode. r=stransky, a=RyanVM on a CLOSED TREE MozReview-Commit-ID: DuKPGXKqtnD
browser/themes/linux/browser.css
--- a/browser/themes/linux/browser.css
+++ b/browser/themes/linux/browser.css
@@ -645,22 +645,22 @@ notification[value="translation"] menuli
 @media (-moz-gtk-csd-available) {
   :root[tabsintitlebar] > #titlebar:-moz-lwtheme {
     visibility: hidden;
   }
   :root[tabsintitlebar] #titlebar-content:-moz-lwtheme {
     visibility: visible;
   }
 
+  :root[tabsintitlebar] > #titlebar {
+    -moz-appearance: -moz-window-titlebar-maximized;
+  }
   :root[tabsintitlebar][sizemode="normal"] > #titlebar {
     -moz-appearance: -moz-window-titlebar;
   }
-  :root[tabsintitlebar][sizemode="maximized"] > #titlebar {
-    -moz-appearance: -moz-window-titlebar-maximized;
-  }
 
   /* Add extra space to titlebar for dragging */
   :root[sizemode="normal"][chromehidden~="menubar"] #TabsToolbar,
   :root[sizemode="normal"] #toolbar-menubar[autohide="true"][inactive] + #TabsToolbar {
     padding-top: var(--space-above-tabbar);
   }
 
   /* Private browsing and accessibility indicators */
@@ -669,17 +669,18 @@ notification[value="translation"] menuli
   :root[sizemode="normal"] #toolbar-menubar[autohide="true"][inactive] + #TabsToolbar > .private-browsing-indicator,
   :root[sizemode="normal"] #toolbar-menubar[autohide="true"][inactive] + #TabsToolbar > .accessibility-indicator {
     padding-top: calc(-1 * var(--space-above-tabbar));
   }
 
   /* Make #TabsToolbar transparent as we style underlying #titlebar with
    * -moz-window-titlebar (Gtk+ theme).
    */
-  :root[tabsintitlebar] #TabsToolbar,
+  :root[tabsintitlebar][sizemode="normal"]:not([inFullscreen]) #TabsToolbar,
+  :root[tabsintitlebar][sizemode="maximized"] #TabsToolbar,
   :root[tabsintitlebar] #toolbar-menubar {
     -moz-appearance: none;
   }
 
   /* The button box must appear on top of the navigator-toolbox in order for
    * click and hover mouse events to work properly for the button in the restored
    * window state. Otherwise, elements in the navigator-toolbox, like the menubar,
    * can swallow those events.