Bug 1434662 - Remove dead code. r=gcp
☠☠ backed out by 81983b3a3475 ☠ ☠
authorFrancois Marier <francois@mozilla.com>
Thu, 19 Apr 2018 16:06:40 -0700
changeset 468570 39b9f46104ad5f26fc5333f5305e150f38abfafa
parent 468569 6f652d798a0cf15e7b63cf1b2e68358b9dc023f2
child 468571 983099e546d8ac5f677203e0ae39365164b1a131
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgcp
bugs1434662, 1296820
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1434662 - Remove dead code. r=gcp This check was added in bug 1296820 to disable V4 updates prior to their being implemented. It should have been removed once we landed working support for V4 updates. MozReview-Commit-ID: 828DIS72LNi
toolkit/components/url-classifier/nsUrlClassifierDBService.cpp
--- a/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp
+++ b/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp
@@ -688,21 +688,16 @@ nsUrlClassifierDBServiceWorker::NotifyUp
   // Null out mUpdateObserver before notifying so that BeginUpdate()
   // becomes available prior to callback.
   nsCOMPtr<nsIUrlClassifierUpdateObserver> updateObserver = nullptr;
   updateObserver.swap(mUpdateObserver);
 
   if (NS_SUCCEEDED(mUpdateStatus)) {
     LOG(("Notifying success: %d", mUpdateWaitSec));
     updateObserver->UpdateSuccess(mUpdateWaitSec);
-  } else if (NS_ERROR_NOT_IMPLEMENTED == mUpdateStatus) {
-    LOG(("Treating NS_ERROR_NOT_IMPLEMENTED a successful update "
-         "but still mark it spoiled."));
-    updateObserver->UpdateSuccess(0);
-    mClassifier->ResetTables(Classifier::Clear_Cache, mUpdateTables);
   } else {
     if (LOG_ENABLED()) {
       nsAutoCString errorName;
       mozilla::GetErrorName(mUpdateStatus, errorName);
       LOG(("Notifying error: %s (%" PRIu32 ")", errorName.get(),
            static_cast<uint32_t>(mUpdateStatus)));
     }