Bug 1429904 - Remove mHash which is now unused. It was only used by FrameKey::operator<. r=njn
☠☠ backed out by bf5a8698216c ☠ ☠
authorMarkus Stange <mstange@themasta.com>
Tue, 27 Feb 2018 23:06:31 -0500
changeset 458294 39a1b2434439f995c2d257aa89840a4418a8ca61
parent 458293 e270b4748814ef821e7a5af20ce94572f08e6dcd
child 458295 595906406c168abe0276e68c5681ab67bad2268b
push id8808
push userarchaeopteryx@coole-files.de
push dateFri, 02 Mar 2018 22:13:05 +0000
treeherdermozilla-beta@7475508d19db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnjn
bugs1429904
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1429904 - Remove mHash which is now unused. It was only used by FrameKey::operator<. r=njn MozReview-Commit-ID: 5Jc6EYmoZfS
tools/profiler/core/ProfileBufferEntry.h
--- a/tools/profiler/core/ProfileBufferEntry.h
+++ b/tools/profiler/core/ProfileBufferEntry.h
@@ -176,41 +176,35 @@ public:
     mozilla::Maybe<unsigned> mLine;
     mozilla::Maybe<unsigned> mCategory;
     mozilla::Maybe<JITAddress> mJITAddress;
     mozilla::Maybe<uint32_t> mJITDepth;
 
     explicit FrameKey(const char* aLocation)
      : mLocation(aLocation)
     {
-      mHash = Hash();
     }
 
     FrameKey(const FrameKey& aToCopy)
      : mLocation(aToCopy.mLocation)
      , mLine(aToCopy.mLine)
      , mCategory(aToCopy.mCategory)
      , mJITAddress(aToCopy.mJITAddress)
      , mJITDepth(aToCopy.mJITDepth)
     {
-      mHash = Hash();
     }
 
     FrameKey(const JITAddress& aJITAddress, uint32_t aJITDepth)
      : mJITAddress(mozilla::Some(aJITAddress))
      , mJITDepth(mozilla::Some(aJITDepth))
     {
-      mHash = Hash();
     }
 
     uint32_t Hash() const;
     bool operator==(const FrameKey& aOther) const;
-
-  private:
-    uint32_t mHash;
   };
 
   struct StackKey {
     mozilla::Maybe<uint32_t> mPrefixStackIndex;
     uint32_t mFrameIndex;
 
     explicit StackKey(uint32_t aFrame)
      : mFrameIndex(aFrame)