servo: Merge #17251 - stylo: make {stop, flood}-opacity animatable (from chenpighead:stylo-stop-flood-opacity-animatable); r=hiro
authorJeremy Chen <jeremychen@mozilla.com>
Thu, 08 Jun 2017 23:29:21 -0700
changeset 411300 3888304a47f36783634e92edc1704663b1c84ce5
parent 411299 99fe8edb8296f2cd4f704e7dcad482a4926ca1ac
child 411301 6d3603a87085e02c0123574d97a73b8baf1234d0
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewershiro
bugs17251, 1360133
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
servo: Merge #17251 - stylo: make {stop, flood}-opacity animatable (from chenpighead:stylo-stop-flood-opacity-animatable); r=hiro This is just the servo part change. The test part will be landed in gecko directly. Gecko bug: [Bug 1360133](https://bugzilla.mozilla.org/show_bug.cgi?id=1360133) Source-Repo: https://github.com/servo/servo Source-Revision: 243967298312efa892bed42c421e74f221a99ddd
servo/components/style/properties/longhand/svg.mako.rs
--- a/servo/components/style/properties/longhand/svg.mako.rs
+++ b/servo/components/style/properties/longhand/svg.mako.rs
@@ -23,30 +23,30 @@
     "stop-color", "RGBAColor",
     "RGBA::new(0, 0, 0, 255)",
     products="gecko",
     animation_value_type="none",
     spec="https://www.w3.org/TR/SVGTiny12/painting.html#StopColorProperty")}
 
 ${helpers.predefined_type("stop-opacity", "Opacity", "1.0",
                           products="gecko",
-                          animation_value_type="none",
+                          animation_value_type="ComputedValue",
                           spec="https://www.w3.org/TR/SVGTiny12/painting.html#propdef-stop-opacity")}
 
 // Section 15 - Filter Effects
 
 ${helpers.predefined_type(
     "flood-color", "RGBAColor",
     "RGBA::new(0, 0, 0, 255)",
     products="gecko",
     animation_value_type="none",
     spec="https://www.w3.org/TR/SVG/filters.html#FloodColorProperty")}
 
 ${helpers.predefined_type("flood-opacity", "Opacity",
-                          "1.0", products="gecko", animation_value_type="none",
+                          "1.0", products="gecko", animation_value_type="ComputedValue",
                           spec="https://www.w3.org/TR/SVG/filters.html#FloodOpacityProperty")}
 
 ${helpers.predefined_type(
     "lighting-color", "RGBAColor",
     "RGBA::new(255, 255, 255, 255)",
     products="gecko",
     animation_value_type="none",
     spec="https://www.w3.org/TR/SVG/filters.html#LightingColorProperty")}