Bug 1512274 - [geckoview] Make all argument names be lowerCamelCase. r=geckoview-reviewers,snorp
☠☠ backed out by 1f911d12fd07 ☠ ☠
authorAgi Sferro <agi@mozilla.com>
Fri, 15 Mar 2019 18:08:38 +0000
changeset 522086 380cdbe5557c86bed91f985824cee75321ee282c
parent 522085 58642fa9c95b0aad2f6adae8b8005f17e41541fc
child 522087 5d02f27fe1747a473a400e8473dc3acf0a365ea1
push id10871
push usercbrindusan@mozilla.com
push dateMon, 18 Mar 2019 15:49:32 +0000
treeherdermozilla-beta@018abdd16060 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgeckoview-reviewers, snorp
bugs1512274
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1512274 - [geckoview] Make all argument names be lowerCamelCase. r=geckoview-reviewers,snorp Depends on D23683 Differential Revision: https://phabricator.services.mozilla.com/D23684
mobile/android/geckoview/src/main/java/org/mozilla/gecko/AndroidGamepadManager.java
mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java
mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoNetworkManager.java
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/AndroidGamepadManager.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/AndroidGamepadManager.java
@@ -180,21 +180,21 @@ public class AndroidGamepadManager {
             removeDeviceListener(context);
             sPendingGamepads.clear();
             sGamepads.clear();
             sStarted = false;
         }
     }
 
     @WrapForJNI
-    private static void onGamepadAdded(final int device_id, final int service_id) {
+    private static void onGamepadAdded(final int deviceId, final int serviceId) {
         ThreadUtils.postToUiThread(new Runnable() {
             @Override
             public void run() {
-                handleGamepadAdded(device_id, service_id);
+                handleGamepadAdded(deviceId, serviceId);
             }
         });
     }
 
     /* package */ static void handleGamepadAdded(final int deviceId, final int serviceId) {
         ThreadUtils.assertOnUiThread();
         if (!sStarted) {
             return;
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java
@@ -388,17 +388,17 @@ public class GeckoAppShell
     }
 
     @WrapForJNI(calledFrom = "gecko")
     private static void enableLocationHighAccuracy(final boolean enable) {
         locationHighAccuracyEnabled = enable;
     }
 
     @WrapForJNI(calledFrom = "ui", dispatchTo = "gecko")
-    /* package */ static native void onSensorChanged(int hal_type, float x, float y, float z,
+    /* package */ static native void onSensorChanged(int halType, float x, float y, float z,
                                                      float w, long time);
 
     @WrapForJNI(calledFrom = "any", dispatchTo = "gecko")
     /* package */ static native void onLocationChanged(double latitude, double longitude,
                                                        double altitude, float accuracy,
                                                        float altitudeAccuracy,
                                                        float heading, float speed, long time);
 
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoNetworkManager.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoNetworkManager.java
@@ -312,17 +312,17 @@ public class GeckoNetworkManager extends
         currentConnectionType = NetworkUtils.getConnectionType(connectivityManager);
         currentNetworkStatus = NetworkUtils.getNetworkStatus(connectivityManager);
         currentConnectionSubtype = NetworkUtils.getConnectionSubType(connectivityManager);
         Log.d(LOGTAG, "New network state: " + currentNetworkStatus + ", " + currentConnectionType + ", " + currentConnectionSubtype);
     }
 
     @WrapForJNI(dispatchTo = "gecko")
     private static native void onConnectionChanged(int type, String subType,
-                                                   boolean isWifi, int DHCPGateway);
+                                                   boolean isWifi, int dhcpGateway);
 
     @WrapForJNI(dispatchTo = "gecko")
     private static native void onStatusChanged(String status);
 
     /**
      * Send current network state and connection type to whomever is listening.
      */
     private void sendNetworkStateToListeners(final Context context) {