Bug 1455143 - Remove hash name validation; r=ted
authorGregory Szorc <gps@mozilla.com>
Wed, 18 Apr 2018 15:31:59 -0700
changeset 468152 37fec60424380f4a64d2f568d644e26679a2f99f
parent 468151 4c987b999ff1123be2596d1eed4d790bb3c57b8f
child 468153 e6d309fde362cef30e20aba408958cbce3884425
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted
bugs1455143
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1455143 - Remove hash name validation; r=ted Garbage in garbage out. Let's make this code simpler. MozReview-Commit-ID: Gv0ZcMacyOX
build/checksums.py
--- a/build/checksums.py
+++ b/build/checksums.py
@@ -127,23 +127,16 @@ def main():
 
     # Set up logging
     setup_logging(loglevel)
     logger = logging.getLogger('checksums.py')
 
     # Validate the digest type to use
     if not options.digests:
         options.digests = ['sha1']
-    try:
-        for digest in options.digests:
-            hashlib.new(digest)
-    except ValueError as ve:
-        logger.error('Could not create a "%s" hash object (%s)' %
-                     (digest, ve.args[0]))
-        exit(1)
 
     # Validate the files to checksum
     files = []
     for i in args:
         if os.path.exists(i):
             files.append(i)
         else:
             logger.info('File "%s" was not found on the filesystem' % i)