Bug 1533074 - Implement Fingerprinting and Cryptomining annotation features - Part 5 - Correct pref checks, r=dimi
☠☠ backed out by 4d0c32fbf17c ☠ ☠
authorAndrea Marchesini <amarchesini@mozilla.com>
Thu, 14 Mar 2019 06:32:42 +0000
changeset 521849 36c6a7178a5c8e1ee75821396f904583c3ecba7a
parent 521848 7e6a8fadff5ba02444e977b5dcaa8d479dfa3341
child 521850 33d53c6ee1362f77a600c3486646ae6e3816d8fb
push id10870
push usernbeleuzu@mozilla.com
push dateFri, 15 Mar 2019 20:00:07 +0000
treeherdermozilla-beta@c594aee5b7a4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdimi
bugs1533074
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1533074 - Implement Fingerprinting and Cryptomining annotation features - Part 5 - Correct pref checks, r=dimi Differential Revision: https://phabricator.services.mozilla.com/D23104
netwerk/url-classifier/AsyncUrlChannelClassifier.cpp
--- a/netwerk/url-classifier/AsyncUrlChannelClassifier.cpp
+++ b/netwerk/url-classifier/AsyncUrlChannelClassifier.cpp
@@ -411,17 +411,18 @@ bool FeatureData::MaybeCompleteClassific
   nsresult rv = mFeature->GetSkipHostList(skipList);
   if (NS_WARN_IF(NS_FAILED(rv))) {
     UC_LOG(
         ("FeatureData::MaybeCompleteClassification[%p] - error. Let's move on",
          this));
     return true;
   }
 
-  if (nsContentUtils::IsURIInList(mBlacklistTables[0]->URI(), skipList)) {
+  if (!mBlacklistTables.IsEmpty() &&
+      nsContentUtils::IsURIInList(mBlacklistTables[0]->URI(), skipList)) {
     UC_LOG(
         ("FeatureData::MaybeCompleteClassification[%p] - uri found in skiplist",
          this));
     return true;
   }
 
   nsAutoCString list;
   list.Assign(mHostInPrefTables[nsIUrlClassifierFeature::blacklist]);