Bug 1366474: While we're here, devirtualize GetSMILOverrideStyle too. r=birtles
authorEmilio Cobos Álvarez <emilio@crisal.io>
Sat, 20 May 2017 13:02:43 +0200
changeset 407970 367944041b558ffe29edf64e8c83879a348de0ca
parent 407969 c91c70a13c4a71f039a56fdd777711e5fbb5be68
child 407981 9851fcb0bf4d855c36729d7de19f0fa5c9f69776
child 407982 fc83b1849a3526f357dfe3d32dc1ec2ede481423
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbirtles
bugs1366474
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1366474: While we're here, devirtualize GetSMILOverrideStyle too. r=birtles Also, update an outdated comment that was leftover. MozReview-Commit-ID: CC865rj3o3S
dom/base/Element.h
dom/base/FragmentOrElement.h
--- a/dom/base/Element.h
+++ b/dom/base/Element.h
@@ -352,17 +352,17 @@ public:
   /**
    * Get the SMIL override style for this element. This is a style declaration
    * that is applied *after* the inline style, and it can be used e.g. to store
    * animated style values.
    *
    * Note: This method is analogous to the 'GetStyle' method in
    * nsGenericHTMLElement and nsStyledElement.
    */
-  virtual nsICSSDeclaration* GetSMILOverrideStyle();
+  nsICSSDeclaration* GetSMILOverrideStyle();
 
   /**
    * Returns if the element is labelable as per HTML specification.
    */
   virtual bool IsLabelable() const;
 
   /**
    * Returns if the element is interactive content as per HTML specification.
--- a/dom/base/FragmentOrElement.h
+++ b/dom/base/FragmentOrElement.h
@@ -270,17 +270,17 @@ public:
     /**
      * The .dataset attribute.
      * @see nsGenericHTMLElement::GetDataset
      */
     nsDOMStringMap* mDataset; // [Weak]
 
     /**
      * SMIL Overridde style rules (for SMIL animation of CSS properties)
-     * @see nsIContent::GetSMILOverrideStyle
+     * @see Element::GetSMILOverrideStyle
      */
     nsCOMPtr<nsICSSDeclaration> mSMILOverrideStyle;
 
     /**
      * Holds any SMIL override style declaration for this element.
      */
     RefPtr<mozilla::DeclarationBlock> mSMILOverrideStyleDeclaration;