Backed out changeset a76116eb180c (bug 1637617) for assertion failure: !Failed() . CLOSED TREE
authorNarcis Beleuzu <nbeleuzu@mozilla.com>
Wed, 03 Jun 2020 03:34:23 +0300
changeset 597710 35e029c1b626adc8f759dae563d4b1d2077a4709
parent 597709 412ba3cc742c0ab84297ad9ca22c3dc8051f62e3
child 597711 233196e86939e937728f2b8e81277e548cc2844e
push id13310
push userffxbld-merge
push dateMon, 29 Jun 2020 14:50:06 +0000
treeherdermozilla-beta@15a59a0afa5c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1637617
milestone79.0a1
backs outa76116eb180c3cacdd1cb555d1bc4ac54c9d2f5e
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset a76116eb180c (bug 1637617) for assertion failure: !Failed() . CLOSED TREE
browser/components/customizableui/content/panelUI.inc.xhtml
browser/themes/shared/customizableui/panelUI.inc.css
--- a/browser/components/customizableui/content/panelUI.inc.xhtml
+++ b/browser/components/customizableui/content/panelUI.inc.xhtml
@@ -970,19 +970,16 @@
                        label-show="&viewBookmarksToolbar.label;"
                        label-hide="&hideBookmarksToolbar.label;"
                        oncommand="BookmarkingUI.toggleBookmarksToolbar();"/>
       </vbox>
     </panelview>
 
     <panelview id="PanelUI-whatsNew" class="PanelUI-subView">
       <vbox class="panel-subview-body">
-        <box id="PanelUI-whatsNew-title" class="panel-header">
-          <label data-l10n-id="cfr-whatsnew-panel-header"/>
-        </box>
         <toolbaritem id="PanelUI-whatsNew-content"
                      orient="vertical"
                      smoothscroll="false">
           <html:div id="PanelUI-whatsNew-message-container" role="document">
             <!-- What's New messages will be rendered here -->
           </html:div>
         </toolbaritem>
       </vbox>
--- a/browser/themes/shared/customizableui/panelUI.inc.css
+++ b/browser/themes/shared/customizableui/panelUI.inc.css
@@ -1851,21 +1851,16 @@ toolbarpaletteitem[place="menu-panel"] >
   display: block;
   margin: 12px 0;
 }
 
 panelview[mainview] #PanelUI-whatsNew-content {
   height: 43em;
 }
 
-/* Hide the What's New header when the panel is a subview */
-panelview:not([mainview]) #PanelUI-whatsNew-title {
-  display: none;
-}
-
 #PanelUI-whatsNew .panel-subview-body {
   padding-top: 0;
 }
 
 #PanelUI-whatsNew .panelMenu-toggleWhatsNew-checkbox {
   background-color: var(--arrowpanel-dimmed);
   border-top: 1px solid var(--panel-separator-color);
   padding-inline-start: 18px;
@@ -1899,33 +1894,33 @@ panelview:not([mainview]) #PanelUI-whats
 #PanelUI-whatsNew .checkbox-check {
   -moz-appearance: none;
   width: 20px;
   height: 20px;
   padding: 1px;
   border: 1px solid #A9A9A9;
   border-radius: 2px;
   margin: 0;
-  margin-inline-end: 6px;
+  margin-inline-end: 10px;
   background-color: #FFF;
   background-position: center;
   background-repeat: no-repeat;
 }
 
 #PanelUI-whatsNew checkbox:hover .checkbox-check {
   border-color: #0a84ff;
 }
 
 #PanelUI-whatsNew .checkbox-icon {
   display: none;
 }
 
 #PanelUI-whatsNew .whatsNew-message {
   cursor: pointer;
-  margin: 0;
+  margin: 0 12px;
   padding: 0;
 }
 
 /* The following 2 rules show a 1 pixel line separator between What's New
  * messages while at the same time ensuring that the first message (which has
  * a date header) will not show the separator
  */
 #PanelUI-whatsNew .whatsNew-message-body::before {
@@ -1940,24 +1935,22 @@ panelview:not([mainview]) #PanelUI-whats
 #PanelUI-whatsNew .whatsNew-message-date + .whatsNew-message-body::before {
   display: none;
 }
 
 #PanelUI-whatsNew .whatsNew-message-date {
   font-size: .85em;
   margin: -12px;
   margin-top: 0;
-  margin-inline-start: 0;
   padding: 6px 16px;
   background: var(--arrowpanel-dimmed);
 }
 
 #PanelUI-whatsNew .whatsNew-message-body {
-  padding: 5px 0 10px;
-  margin-inline-start: 12px;
+  padding: 6px 6px 10px;
   text-align: inherit;
   text-decoration: none;
   color: inherit;
   background: none;
   border: none;
   cursor: pointer;
 }
 
@@ -1972,17 +1965,17 @@ panelview:not([mainview]) #PanelUI-whats
   display: flex;
   flex-direction: column;
 }
 
 #PanelUI-whatsNew .whatsNew-message-icon {
   inset-inline-end: 6px;
   height: 32px;
   position: absolute;
-  top: 24px;
+  top: 22px;
   width: 32px;
 }
 
 #PanelUI-whatsNew .whatsNew-message-title,
 #protections-popup-message .whatsNew-message-title {
   display: block;
   padding-inline-end: 46px;
   font-size: 1.3em;
@@ -2001,17 +1994,17 @@ panelview:not([mainview]) #PanelUI-whats
   margin: 2px 0;
   font-size: .8em;
   color: #949494;
   font-weight: normal;
 }
 
 #PanelUI-whatsNew .whatsNew-message-content {
   display: block;
-  margin: 5px 0 10px;
+  margin: 10px 0;
 }
 
 #PanelUI-whatsNew .text-link {
   background: none;
   border: 0;
   color: #45a1ff;
   cursor: pointer;
   font-size: .9em;