servo: Merge #17216 - Fix serialisation of computed circle() shapes (from nox:fix-computed-circle-serialisation); r=canaltinova
authorAnthony Ramine <n.oxyde@gmail.com>
Wed, 07 Jun 2017 17:31:17 -0700
changeset 411007 351a87f24a6f9f315567ec3db089db79c4c14981
parent 411006 dedcbcd211227eb2fbf866d61a0a83d69090366b
child 411008 a5c1b2aba36c6ca27136cef41995fe53ee500a70
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscanaltinova
bugs17216
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
servo: Merge #17216 - Fix serialisation of computed circle() shapes (from nox:fix-computed-circle-serialisation); r=canaltinova Source-Repo: https://github.com/servo/servo Source-Revision: 1ea4a44fad4dfd6d7ca1152e06cf07b7e927951b
servo/components/style/values/computed/basic_shape.rs
--- a/servo/components/style/values/computed/basic_shape.rs
+++ b/servo/components/style/values/computed/basic_shape.rs
@@ -36,17 +36,18 @@ pub type Ellipse = GenericEllipse<Length
 /// The computed value of `ShapeRadius`
 pub type ShapeRadius = GenericShapeRadius<LengthOrPercentage>;
 
 impl ToCss for Circle {
     fn to_css<W>(&self, dest: &mut W) -> fmt::Result where W: fmt::Write {
         dest.write_str("circle(")?;
         self.radius.to_css(dest)?;
         dest.write_str(" at ")?;
-        self.position.to_css(dest)
+        self.position.to_css(dest)?;
+        dest.write_str(")")
     }
 }
 
 impl ToCss for Ellipse {
     fn to_css<W>(&self, dest: &mut W) -> fmt::Result where W: fmt::Write {
         dest.write_str("ellipse(")?;
         if (self.semiaxis_x, self.semiaxis_y) != Default::default() {
             self.semiaxis_x.to_css(dest)?;