Bug 1551089 - prevent runnning static analysis on the entire repo when using `--fix` option. r=sylvestre
authorAndi-Bogdan Postelnicu <bpostelnicu@mozilla.com>
Sun, 12 May 2019 19:39:56 +0000
changeset 532383 340b1a7c0c3ca75fc343d73c106db1b3ef8904e4
parent 532382 d77d76d37d4dccf39c12fa81c970088b5388d0f1
child 532384 12d0981bc456c88396f3819aa64aa81d8f67cb66
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssylvestre
bugs1551089
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1551089 - prevent runnning static analysis on the entire repo when using `--fix` option. r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D30829
python/mozbuild/mozbuild/mach_commands.py
--- a/python/mozbuild/mozbuild/mach_commands.py
+++ b/python/mozbuild/mozbuild/mach_commands.py
@@ -2415,17 +2415,17 @@ class StaticAnalysis(MachCommandBase):
         # From our configuration file, config.yaml, we build the configuration list, for
         # the checkers that are used. These configuration options are used to better fit
         # the checkers to our code.
         cfg = self._get_checks_config()
         if cfg:
             common_args += ['-config=%s' % yaml.dump(cfg)]
 
         if fix:
-            common_args += '-fix'
+            common_args += ['-fix']
 
         return [
             self.virtualenv_manager.python_path, self._run_clang_tidy_path, '-j',
             str(jobs), '-p', self._compilation_commands_path
         ] + common_args + sources
 
     def _check_for_java(self):
         '''Check if javac can be found.'''