Backed out changeset b404fd242e7f (bug 1545196) for browser-chrome failures at projects/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cc
authorCoroiu Cristina <ccoroiu@mozilla.com>
Thu, 23 Jan 2020 17:07:32 +0200
changeset 573987 332ffb5bdfba7acccc2c8353d75930d648d5d9ed
parent 573986 ee4b15857843597bc408305c170ff30a02ede1cc
child 573988 2fbc8cd3c4f59d4ba1b31f34f7883d3453e67f18
push id12662
push userffxbld-merge
push dateMon, 10 Feb 2020 10:43:10 +0000
treeherdermozilla-beta@ace4081e8200 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1545196
milestone74.0a1
backs outb404fd242e7f1bf4a77c9cbb5361f38d2c9e7166
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset b404fd242e7f (bug 1545196) for browser-chrome failures at projects/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cc CLOSED TREE
dom/indexedDB/ActorsParent.cpp
ipc/glue/IPCMessageUtils.h
--- a/dom/indexedDB/ActorsParent.cpp
+++ b/dom/indexedDB/ActorsParent.cpp
@@ -6428,17 +6428,17 @@ class TransactionBase {
     // step 5.3 vs. 5.4).
     if (NS_FAILED(aResultCode)) {
       mHasFailedRequest = true;
     }
 
     CommitOrAbort();
   }
 
-  PBackgroundIDBRequestParent* AllocRequest(RequestParams&& aParams,
+  PBackgroundIDBRequestParent* AllocRequest(const RequestParams& aParams,
                                             bool aTrustParams);
 
   bool StartRequest(PBackgroundIDBRequestParent* aActor);
 
   bool DeallocRequest(PBackgroundIDBRequestParent* aActor);
 
   PBackgroundIDBCursorParent* AllocCursor(const OpenCursorParams& aParams,
                                           bool aTrustParams);
@@ -7410,17 +7410,17 @@ class ObjectStoreAddOrPutRequestOp final
   const PersistenceType mPersistenceType;
   const bool mOverwrite;
   bool mObjectStoreMayHaveIndexes;
   bool mDataOverThreshold;
 
  private:
   // Only created by TransactionBase.
   ObjectStoreAddOrPutRequestOp(RefPtr<TransactionBase> aTransaction,
-                               RequestParams&& aParams);
+                               const RequestParams& aParams);
 
   ~ObjectStoreAddOrPutRequestOp() override = default;
 
   nsresult RemoveOldIndexDataValues(DatabaseConnection* aConnection);
 
   bool Init(TransactionBase* aTransaction) override;
 
   nsresult DoDatabaseWork(DatabaseConnection* aConnection) override;
@@ -14653,17 +14653,17 @@ void TransactionBase::Invalidate() {
     mInvalidated.Flip();
     mInvalidatedOnAnyThread = true;
 
     Abort(NS_ERROR_DOM_INDEXEDDB_ABORT_ERR, /* aForce */ false);
   }
 }
 
 PBackgroundIDBRequestParent* TransactionBase::AllocRequest(
-    RequestParams&& aParams, bool aTrustParams) {
+    const RequestParams& aParams, bool aTrustParams) {
   AssertIsOnBackgroundThread();
   MOZ_ASSERT(aParams.type() != RequestParams::T__None);
 
 #ifdef DEBUG
   // Always verify parameters in DEBUG builds!
   aTrustParams = false;
 #endif
 
@@ -14677,17 +14677,17 @@ PBackgroundIDBRequestParent* Transaction
     return nullptr;
   }
 
   RefPtr<NormalTransactionOp> actor;
 
   switch (aParams.type()) {
     case RequestParams::TObjectStoreAddParams:
     case RequestParams::TObjectStorePutParams:
-      actor = new ObjectStoreAddOrPutRequestOp(this, std::move(aParams));
+      actor = new ObjectStoreAddOrPutRequestOp(this, aParams);
       break;
 
     case RequestParams::TObjectStoreGetParams:
       actor = new ObjectStoreGetRequestOp(this, aParams, /* aGetAll */ false);
       break;
 
     case RequestParams::TObjectStoreGetAllParams:
       actor = new ObjectStoreGetRequestOp(this, aParams, /* aGetAll */ true);
@@ -14953,18 +14953,17 @@ mozilla::ipc::IPCResult NormalTransactio
 }
 
 PBackgroundIDBRequestParent*
 NormalTransaction::AllocPBackgroundIDBRequestParent(
     const RequestParams& aParams) {
   AssertIsOnBackgroundThread();
   MOZ_ASSERT(aParams.type() != RequestParams::T__None);
 
-  return AllocRequest(std::move(const_cast<RequestParams&>(aParams)),
-                      IsSameProcessActor());
+  return AllocRequest(aParams, IsSameProcessActor());
 }
 
 mozilla::ipc::IPCResult NormalTransaction::RecvPBackgroundIDBRequestConstructor(
     PBackgroundIDBRequestParent* const aActor, const RequestParams& aParams) {
   AssertIsOnBackgroundThread();
   MOZ_ASSERT(aActor);
   MOZ_ASSERT(aParams.type() != RequestParams::T__None);
 
@@ -15587,18 +15586,17 @@ mozilla::ipc::IPCResult VersionChangeTra
 }
 
 PBackgroundIDBRequestParent*
 VersionChangeTransaction::AllocPBackgroundIDBRequestParent(
     const RequestParams& aParams) {
   AssertIsOnBackgroundThread();
   MOZ_ASSERT(aParams.type() != RequestParams::T__None);
 
-  return AllocRequest(std::move(const_cast<RequestParams&>(aParams)),
-                      IsSameProcessActor());
+  return AllocRequest(aParams, IsSameProcessActor());
 }
 
 mozilla::ipc::IPCResult
 VersionChangeTransaction::RecvPBackgroundIDBRequestConstructor(
     PBackgroundIDBRequestParent* aActor, const RequestParams& aParams) {
   AssertIsOnBackgroundThread();
   MOZ_ASSERT(aActor);
   MOZ_ASSERT(aParams.type() != RequestParams::T__None);
@@ -24699,22 +24697,21 @@ mozilla::ipc::IPCResult NormalTransactio
   }
 
   NoteContinueReceived();
 
   return IPC_OK();
 }
 
 ObjectStoreAddOrPutRequestOp::ObjectStoreAddOrPutRequestOp(
-    RefPtr<TransactionBase> aTransaction, RequestParams&& aParams)
+    RefPtr<TransactionBase> aTransaction, const RequestParams& aParams)
     : NormalTransactionOp(std::move(aTransaction)),
-      mParams(
-          std::move(aParams.type() == RequestParams::TObjectStoreAddParams
-                        ? aParams.get_ObjectStoreAddParams().commonParams()
-                        : aParams.get_ObjectStorePutParams().commonParams())),
+      mParams(aParams.type() == RequestParams::TObjectStoreAddParams
+                  ? aParams.get_ObjectStoreAddParams().commonParams()
+                  : aParams.get_ObjectStorePutParams().commonParams()),
       mGroup(Transaction().GetDatabase()->Group()),
       mOrigin(Transaction().GetDatabase()->Origin()),
       mPersistenceType(Transaction().GetDatabase()->Type()),
       mOverwrite(aParams.type() == RequestParams::TObjectStorePutParams),
       mObjectStoreMayHaveIndexes(false) {
   MOZ_ASSERT(aParams.type() == RequestParams::TObjectStoreAddParams ||
              aParams.type() == RequestParams::TObjectStorePutParams);
 
--- a/ipc/glue/IPCMessageUtils.h
+++ b/ipc/glue/IPCMessageUtils.h
@@ -73,21 +73,16 @@ struct void_t {
 struct null_t {
   bool operator==(const null_t&) const { return true; }
 };
 
 struct SerializedStructuredCloneBuffer final {
   SerializedStructuredCloneBuffer()
       : data(JS::StructuredCloneScope::Unassigned) {}
 
-  SerializedStructuredCloneBuffer(SerializedStructuredCloneBuffer&&) noexcept =
-      default;
-  SerializedStructuredCloneBuffer& operator=(
-      SerializedStructuredCloneBuffer&&) noexcept = default;
-
   SerializedStructuredCloneBuffer(const SerializedStructuredCloneBuffer& aOther)
       : SerializedStructuredCloneBuffer() {
     *this = aOther;
   }
 
   SerializedStructuredCloneBuffer& operator=(
       const SerializedStructuredCloneBuffer& aOther) {
     data.Clear();