Bug 1379785 - Stop calling abspath on symbol_archive paths. r=gps a=jorgk DONTBUILD THUNDERBIRD550b2_2017071401_RELBRANCH
authorTom Prince <mozilla@hocat.ca>
Mon, 10 Jul 2017 15:25:04 -0600
branchTHUNDERBIRD550b2_2017071401_RELBRANCH
changeset 411964 33216ed37a1fba6289b4e92000afe0be233e3b06
parent 411610 9622d8d4d312b629be5e4ee3ac0d37c2cabddd37
child 411965 ac7ca0c59319862d575a8cc7260275f36271a0ed
push id7509
push usermozilla@jorgk.com
push dateFri, 14 Jul 2017 09:28:47 +0000
treeherdermozilla-beta@33216ed37a1f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgps, jorgk
bugs1379785
milestone55.0
Bug 1379785 - Stop calling abspath on symbol_archive paths. r=gps a=jorgk DONTBUILD Thunderbird is still using MOZ_PKG_PRETTYNAMES which has spaces in the package name, which gets mangled by abspath. MozReview-Commit-ID: 23ngx6gIESI
Makefile.in
--- a/Makefile.in
+++ b/Makefile.in
@@ -260,26 +260,26 @@ prepsymbolsarchive:
 
 ifndef MOZ_AUTOMATION
 prepsymbolsarchive: recurse_syms
 endif
 
 .PHONY: symbolsfullarchive
 symbolsfullarchive: prepsymbolsarchive
 	$(RM) '$(DIST)/$(PKG_PATH)$(SYMBOL_FULL_ARCHIVE_BASENAME).zip'
-	$(call py_action,symbols_archive,$(abspath '$(DIST)/$(PKG_PATH)$(SYMBOL_FULL_ARCHIVE_BASENAME).zip') \
+	$(call py_action,symbols_archive,'$(DIST)/$(PKG_PATH)$(SYMBOL_FULL_ARCHIVE_BASENAME).zip' \
                                      $(abspath $(DIST)/crashreporter-symbols) \
                                      --exclude '*test*' \
                                      --exclude '*Test*' \
                                      --compress '**/*.sym')
 
 .PHONY: symbolsarchive
 symbolsarchive: prepsymbolsarchive
 	$(RM) '$(DIST)/$(PKG_PATH)$(SYMBOL_ARCHIVE_BASENAME).zip'
-	$(call py_action,symbols_archive,$(abspath '$(DIST)/$(PKG_PATH)$(SYMBOL_ARCHIVE_BASENAME).zip') \
+	$(call py_action,symbols_archive,'$(DIST)/$(PKG_PATH)$(SYMBOL_ARCHIVE_BASENAME).zip' \
                                      $(abspath $(DIST)/crashreporter-symbols) \
                                      --include '**/*.sym')
 
 ifdef MOZ_CRASHREPORTER
 buildsymbols: symbolsfullarchive symbolsarchive
 else
 buildsymbols:
 endif