Bug 1539456 - part1: Rename Service Workers menu-item to Remote Debugging r=Ola,flod
authorJulian Descottes <jdescottes@mozilla.com>
Fri, 03 May 2019 11:41:24 +0000
changeset 531284 330882d258d25a37a8479befbc40d94ca675db77
parent 531283 86c7622bc218906e28cf73c18c7e3b867d7839e3
child 531285 b2c043ae6955d68d1ab32fb8ff7e56ccbff53d26
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersOla, flod
bugs1539456
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1539456 - part1: Rename Service Workers menu-item to Remote Debugging r=Ola,flod Removed the Service Workers menu item, added Remote Debugging instead. Remote Debugging is displayed just above WebIDE Differential Revision: https://phabricator.services.mozilla.com/D29219
devtools/client/locales/en-US/menus.properties
devtools/client/menus.js
--- a/devtools/client/locales/en-US/menus.properties
+++ b/devtools/client/locales/en-US/menus.properties
@@ -1,14 +1,17 @@
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-devtoolsServiceWorkers.label = Service Workers
-devtoolsServiceWorkers.accesskey = k
+# LOCALIZATION NOTE (devtoolsRemoteDebugging.label): This is the label for the menu item
+# in Tools > Web Developer. Clicking on this menu item will open about:debugging which
+# acts as a hub for debugging remote devices.
+devtoolsRemoteDebugging.label = Remote Debugging
+devtoolsRemoteDebugging.accesskey = R
 
 devtoolsConnect.label = Connect…
 devtoolsConnect.accesskey = C
 
 browserConsoleCmd.label = Browser Console
 browserConsoleCmd.accesskey = B
 
 responsiveDesignMode.label = Responsive Design Mode
--- a/devtools/client/menus.js
+++ b/devtools/client/menus.js
@@ -49,16 +49,24 @@ exports.menuitems = [
         console.error(`Exception while opening the toolbox: ${e}\n${e.stack}`);
       }
     },
     keyId: "toggleToolbox",
     checkbox: true,
   },
   { id: "menu_devtools_separator",
     separator: true },
+  { id: "menu_devtools_remotedebugging",
+    l10nKey: "devtoolsRemoteDebugging",
+    disabled: true,
+    oncommand(event) {
+      const window = event.target.ownerDocument.defaultView;
+      gDevToolsBrowser.openAboutDebugging(window.gBrowser);
+    },
+  },
   { id: "menu_webide",
     l10nKey: "webide",
     disabled: true,
     oncommand() {
       gDevToolsBrowser.openWebIDE();
     },
     keyId: "webide",
   },
@@ -113,24 +121,16 @@ exports.menuitems = [
   },
   { id: "menu_scratchpad",
     l10nKey: "scratchpad",
     oncommand() {
       ScratchpadManager.openScratchpad();
     },
     keyId: "scratchpad",
   },
-  { id: "menu_devtools_serviceworkers",
-    l10nKey: "devtoolsServiceWorkers",
-    disabled: true,
-    oncommand(event) {
-      const window = event.target.ownerDocument.defaultView;
-      gDevToolsBrowser.openAboutDebugging(window.gBrowser, "workers");
-    },
-  },
   { id: "menu_devtools_connect",
     l10nKey: "devtoolsConnect",
     disabled: true,
     oncommand(event) {
       const window = event.target.ownerDocument.defaultView;
       gDevToolsBrowser.openConnectScreen(window.gBrowser);
     },
   },