Bug 1384895 - Manage Share Providers button icon is wrongly sized and shouldn't use --toolbarbutton-icon-fill. r=johannh
authorDão Gottwald <dao@mozilla.com>
Thu, 27 Jul 2017 15:26:56 +0200
changeset 420170 32cff21188b719ea9f9228dafbd19d69b4378854
parent 420169 433c42e1980fd609bbe00e82c532af1731a4d8f7
child 420171 fcd8bb8c31f75fcf821536a9a20f42437199797c
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjohannh
bugs1384895
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1384895 - Manage Share Providers button icon is wrongly sized and shouldn't use --toolbarbutton-icon-fill. r=johannh The icon is 16x16 rather than 18x18 and --toolbarbutton-icon-fill only makes sense in toolbars. MozReview-Commit-ID: 5IHokX5PrKM
browser/themes/shared/social/social.inc.css
--- a/browser/themes/shared/social/social.inc.css
+++ b/browser/themes/shared/social/social.inc.css
@@ -2,22 +2,18 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 %endif
 
 #manage-share-providers {
   list-style-image: url("chrome://browser/skin/settings.svg");
   -moz-context-properties: fill;
-  fill: var(--toolbarbutton-icon-fill);
-}
-
-#manage-share-providers > .toolbarbutton-icon {
-  min-height: 18px;
-  min-width: 18px;
+  fill: currentColor;
+  color: inherit;
 }
 
 .social-panel > .panel-arrowcontainer > .panel-arrowcontent {
   padding: 0;
 }
 /* fixup corners for share panel */
 .social-panel > .social-panel-frame {
   border-radius: inherit;