Bug 1383501: Assert that com proxy is non-null before calling SendPDocAccessibleConstructor; r=yzen
authorAaron Klotz <aklotz@mozilla.com>
Wed, 06 Sep 2017 10:40:55 -0600
changeset 428899 31ba8f169c5d1d4b118fdd7bd627a991544e7f5a
parent 428898 1e6956da301f796a885e0810090d104eab13a097
child 428900 cb6fcd43e5a505475df2c38a8475bc84d485975b
push id7761
push userjlund@mozilla.com
push dateFri, 15 Sep 2017 00:19:52 +0000
treeherdermozilla-beta@c38455951db4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersyzen
bugs1383501
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1383501: Assert that com proxy is non-null before calling SendPDocAccessibleConstructor; r=yzen MozReview-Commit-ID: CuIXyoe4jsj
accessible/generic/DocAccessible.cpp
--- a/accessible/generic/DocAccessible.cpp
+++ b/accessible/generic/DocAccessible.cpp
@@ -1498,16 +1498,17 @@ DocAccessible::DoInitialUpdate()
         DocAccessibleChild* ipcDoc = new DocAccessibleChild(this, tabChild);
         SetIPCDoc(ipcDoc);
         if (IsRoot()) {
           tabChild->SetTopLevelDocAccessibleChild(ipcDoc);
         }
 
 #if defined(XP_WIN)
         IAccessibleHolder holder(CreateHolderFromAccessible(this));
+        MOZ_DIAGNOSTIC_ASSERT(!holder.IsNull());
         int32_t childID = AccessibleWrap::GetChildIDFor(this);
 #else
         int32_t holder = 0, childID = 0;
 #endif
         tabChild->SendPDocAccessibleConstructor(ipcDoc, nullptr, 0, childID,
                                                 holder);
       }
     }