Bug 1378374 - Remove unnecessary delete calls (r=dvander)
authorBill McCloskey <billm@mozilla.com>
Thu, 27 Jul 2017 15:56:52 -0700
changeset 420580 2fbfb1b926ef82252891b23caa051ba1e73b8f6e
parent 420579 67bb8951ff7142d431409a6fade4064e98537508
child 420581 b0b3cced9169bbf36dd0834218bca511982ef40d
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdvander
bugs1378374
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1378374 - Remove unnecessary delete calls (r=dvander) MozReview-Commit-ID: DGik7IPklWO
dom/ipc/ContentChild.cpp
--- a/dom/ipc/ContentChild.cpp
+++ b/dom/ipc/ContentChild.cpp
@@ -980,32 +980,29 @@ ContentChild::ProvideWindowCommon(TabChi
 
   // =====================
   // End Nested Event Loop
   // =====================
 
   // Handle the error which we got back from the parent process, if we got
   // one.
   if (NS_FAILED(rv)) {
-    PRenderFrameChild::Send__delete__(renderFrame);
     return rv;
   }
 
   if (!*aWindowIsNew) {
-    PRenderFrameChild::Send__delete__(renderFrame);
     return NS_ERROR_ABORT;
   }
 
   // If the TabChild has been torn down, we don't need to do this anymore.
   if (NS_WARN_IF(!newChild->IPCOpen())) {
     return NS_ERROR_ABORT;
   }
 
   if (layersId == 0) { // if renderFrame is invalid.
-    PRenderFrameChild::Send__delete__(renderFrame);
     renderFrame = nullptr;
   }
 
   ShowInfo showInfo(EmptyString(), false, false, true, false, 0, 0, 0);
   auto* opener = nsPIDOMWindowOuter::From(aParent);
   nsIDocShell* openerShell;
   if (opener && (openerShell = opener->GetDocShell())) {
     nsCOMPtr<nsILoadContext> context = do_QueryInterface(openerShell);