Bug 1189554 - Make Saved Passwords dialog resizable on Windows again. r=smaug
authorMike Conley <mconley@mozilla.com>
Tue, 15 Sep 2015 16:33:36 -0400
changeset 295812 2fb84d5bb9b0f9b99ab39dfd993ae32df6e3ea71
parent 295811 af0ad20ecd0b29c4af5cac0fceef5d466858e716
child 295813 dc1cbf8e88a97e00e9daeaa6b7fd279d40cbd016
push id5245
push userraliiev@mozilla.com
push dateThu, 29 Oct 2015 11:30:51 +0000
treeherdermozilla-beta@dac831dc1bd0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug
bugs1189554
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1189554 - Make Saved Passwords dialog resizable on Windows again. r=smaug We were accidentally overwriting chromeFlags with CHROME_DEFAULT, which we should only do if the caller has provided a features string when opening a dialog.
embedding/components/windowwatcher/nsWindowWatcher.cpp
--- a/embedding/components/windowwatcher/nsWindowWatcher.cpp
+++ b/embedding/components/windowwatcher/nsWindowWatcher.cpp
@@ -1605,17 +1605,17 @@ nsWindowWatcher::CalculateChromeFlags(ns
     if (!PL_strcasestr(aFeatures, "titlebar")) {
       chromeFlags |= nsIWebBrowserChrome::CHROME_TITLEBAR;
     }
     if (!PL_strcasestr(aFeatures, "close")) {
       chromeFlags |= nsIWebBrowserChrome::CHROME_WINDOW_CLOSE;
     }
   }
 
-  if (aDialog && !presenceFlag) {
+  if (aDialog && aFeaturesSpecified && !presenceFlag) {
     chromeFlags = nsIWebBrowserChrome::CHROME_DEFAULT;
   }
 
   /* Finally, once all the above normal chrome has been divined, deal
      with the features that are more operating hints than appearance
      instructions. (Note modality implies dependence.) */
 
   if (WinHasOption(aFeatures, "alwaysLowered", 0, nullptr) ||