Backed out changeset 67fac975c2f8 (bug 1517210) for devtools failures in devtools/client/inspector/rules/test/browser_rules_user-agent-styles.js. CLOSED TREE
authorDorel Luca <dluca@mozilla.com>
Tue, 19 Feb 2019 23:59:32 +0200
changeset 517829 2fab580561c0495a87953aaf7a44134186a4b861
parent 517828 86a49f17f7907f48c63cd3787fd796cce6464a7c
child 517830 b51998b9a11bade0e1f8d6a1646539c37f8f8b46
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1517210
milestone67.0a1
backs out67fac975c2f81c99e40b137f9c41bba8c1cb4d85
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 67fac975c2f8 (bug 1517210) for devtools failures in devtools/client/inspector/rules/test/browser_rules_user-agent-styles.js. CLOSED TREE
devtools/client/webconsole/test/mochitest/head.js
devtools/shared/base-loader.js
--- a/devtools/client/webconsole/test/mochitest/head.js
+++ b/devtools/client/webconsole/test/mochitest/head.js
@@ -50,20 +50,16 @@ registerCleanupFunction(async function()
   Services.prefs.getChildList("devtools.webconsole.filter").forEach(pref => {
     Services.prefs.clearUserPref(pref);
   });
   const browserConsole = HUDService.getBrowserConsole();
   if (browserConsole) {
     browserConsole.ui.clearOutput(true);
     await HUDService.toggleBrowserConsole();
   }
-
-  // Bug 1517210 - jsterm tests are crashing with OOM as GC isn't triggerred.
-  // Forcing a GC after each test to prevent these crashes.
-  Cu.forceShrinkingGC();
 });
 
 /**
  * Add a new tab and open the toolbox in it, and select the webconsole.
  *
  * @param string url
  *        The URL for the tab to be opened.
  * @param Boolean clearJstermHistory
--- a/devtools/shared/base-loader.js
+++ b/devtools/shared/base-loader.js
@@ -97,16 +97,19 @@ function Sandbox(options) {
   options = {
     // Do not expose `Components` if you really need them (bad idea!) you
     // still can expose via prototype.
     wantComponents: false,
     sandboxName: options.name,
     sandboxPrototype: "prototype" in options ? options.prototype : {},
     invisibleToDebugger: "invisibleToDebugger" in options ?
                          options.invisibleToDebugger : false,
+    // For now create the sandbox in a new compartment. This is temporary until
+    // bug 1515290 fixes some devtools tests to not rely on this.
+    freshCompartment: true,
   };
 
   const sandbox = Cu.Sandbox(systemPrincipal, options);
 
   delete sandbox.Components;
 
   return sandbox;
 }