Bug 1289438: [ogg] P2. Re-enable earlier test now the seeking behaves as expected. r=cpearce,gerald
authorJean-Yves Avenard <jyavenard@mozilla.com>
Wed, 27 Jul 2016 16:21:47 +1000
changeset 347447 2f6157213da23a19e508bbe2da299e540cb3e54d
parent 347446 1e645059025f3e7aace65f496984a095c9858aa7
child 347448 0f13ecf177c65ee9438b3c32d3a064cde5b29f1e
push id6389
push userraliiev@mozilla.com
push dateMon, 19 Sep 2016 13:38:22 +0000
treeherdermozilla-beta@01d67bfe6c81 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscpearce, gerald
bugs1289438, 666667, 645805
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1289438: [ogg] P2. Re-enable earlier test now the seeking behaves as expected. r=cpearce,gerald Note that the closest keyframes are for video 0.666667 and audio 0.645805, however the current OggReader still incorrectly seeks audio to an earlier time as it seek to the index page boundary. MozReview-Commit-ID: 5g7FHFmRQXD
dom/media/test/manifest.js
--- a/dom/media/test/manifest.js
+++ b/dom/media/test/manifest.js
@@ -547,18 +547,17 @@ var gSeekTests = [
 
 var gFastSeekTests = [
   { name:"gizmo.mp4", type:"video/mp4", keyframes:[0, 1.0, 2.0, 3.0, 4.0, 5.0 ] },
   // Note: Not all keyframes in the file are actually referenced in the Cues in this file.
   { name:"seek.webm", type:"video/webm", keyframes:[0, 0.8, 1.6, 2.4, 3.2]},
   // Note: the sync points are the points on both the audio and video streams
   // before the keyframes. You can't just assume that the keyframes are the sync
   // points, as the audio required for that sync point may be before the keyframe.
-  // We can only seek at the boundary of a page index. see bug 1289438.
-  { name:"bug516323.indexed.ogv", type:"video/ogg", keyframes:[0, 3.06] },
+  { name:"bug516323.indexed.ogv", type:"video/ogg", keyframes:[0, 0.46, 3.06] },
 ];
 
 function IsWindows8OrLater() {
   var re = /Windows NT (\d.\d)/;
   var winver = manifestNavigator().userAgent.match(re);
   return winver && winver.length == 2 && parseFloat(winver[1]) >= 6.2;
 }