Bug 1523969 part 1 - Move method definition inline comments to new line in accessible/. r=jamie
authorRyan Hunt <rhunt@eqrion.net>
Mon, 25 Feb 2019 16:02:26 -0600
changeset 519764 2eff89bd9d57460ecd0e4f74c29396958070734b
parent 519763 0bb343e7c6cc77a950065579d9fc31e0be4c3334
child 519765 cf1a37a3c469b7c0e17c68d65c1e599f11d4172d
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjamie
bugs1523969
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1523969 part 1 - Move method definition inline comments to new line in accessible/. r=jamie Differential Revision: https://phabricator.services.mozilla.com/D21101
accessible/aom/AccessibleNode.cpp
accessible/ipc/DocAccessibleChildBase.cpp
accessible/ipc/win/handler/AccessibleHandlerControl.cpp
accessible/windows/msaa/AccessibleWrap.cpp
accessible/windows/msaa/Compatibility.cpp
dom/media/webrtc/MediaEngineTabVideoSource.cpp
--- a/accessible/aom/AccessibleNode.cpp
+++ b/accessible/aom/AccessibleNode.cpp
@@ -57,22 +57,24 @@ AccessibleNode::AccessibleNode(nsINode* 
   DocAccessible* doc = accService->GetDocAccessible(mDOMNode->OwnerDoc());
   if (doc) {
     mIntl = doc->GetAccessible(mDOMNode);
   }
 }
 
 AccessibleNode::~AccessibleNode() {}
 
-/* virtual */ JSObject* AccessibleNode::WrapObject(
-    JSContext* aCx, JS::Handle<JSObject*> aGivenProto) {
+/* virtual */
+JSObject* AccessibleNode::WrapObject(JSContext* aCx,
+                                     JS::Handle<JSObject*> aGivenProto) {
   return AccessibleNode_Binding::Wrap(aCx, this, aGivenProto);
 }
 
-/* virtual */ ParentObject AccessibleNode::GetParentObject() const {
+/* virtual */
+ParentObject AccessibleNode::GetParentObject() const {
   return mDOMNode->GetParentObject();
 }
 
 void AccessibleNode::GetComputedRole(nsAString& aRole) {
   if (mIntl) {
     nsAccessibilityService* accService = GetOrCreateAccService();
     if (accService) {
       accService->GetStringRole(mIntl->Role(), aRole);
--- a/accessible/ipc/DocAccessibleChildBase.cpp
+++ b/accessible/ipc/DocAccessibleChildBase.cpp
@@ -7,17 +7,18 @@
 #include "mozilla/a11y/DocAccessibleChildBase.h"
 #include "mozilla/a11y/ProxyAccessible.h"
 
 #include "Accessible-inl.h"
 
 namespace mozilla {
 namespace a11y {
 
-/* static */ uint32_t DocAccessibleChildBase::InterfacesFor(Accessible* aAcc) {
+/* static */
+uint32_t DocAccessibleChildBase::InterfacesFor(Accessible* aAcc) {
   uint32_t interfaces = 0;
   if (aAcc->IsHyperText() && aAcc->AsHyperText()->IsTextRole())
     interfaces |= Interfaces::HYPERTEXT;
 
   if (aAcc->IsLink()) interfaces |= Interfaces::HYPERLINK;
 
   if (aAcc->HasNumericValue()) interfaces |= Interfaces::VALUE;
 
@@ -37,18 +38,19 @@ namespace a11y {
 
   if (aAcc->ActionCount()) {
     interfaces |= Interfaces::ACTION;
   }
 
   return interfaces;
 }
 
-/* static */ void DocAccessibleChildBase::SerializeTree(
-    Accessible* aRoot, nsTArray<AccessibleData>& aTree) {
+/* static */
+void DocAccessibleChildBase::SerializeTree(Accessible* aRoot,
+                                           nsTArray<AccessibleData>& aTree) {
   uint64_t id = reinterpret_cast<uint64_t>(aRoot->UniqueID());
 #if defined(XP_WIN)
   int32_t msaaId = AccessibleWrap::GetChildIDFor(aRoot);
 #endif
   a11y::role role = aRoot->Role();
   uint32_t childCount = aRoot->ChildCount();
   uint32_t interfaces = InterfacesFor(aRoot);
 
--- a/accessible/ipc/win/handler/AccessibleHandlerControl.cpp
+++ b/accessible/ipc/win/handler/AccessibleHandlerControl.cpp
@@ -71,22 +71,23 @@ HRESULT
 TextChange::GetNew(long aIA2UniqueId, NotNull<IA2TextSegment*> aOutNewSegment) {
   if (!mIsInsert || aIA2UniqueId != mIA2UniqueId) {
     return S_OK;
   }
 
   return SegCopy(*aOutNewSegment, mText);
 }
 
-/* static */ BSTR TextChange::BSTRCopy(const BSTR& aIn) {
+/* static */
+BSTR TextChange::BSTRCopy(const BSTR& aIn) {
   return ::SysAllocStringLen(aIn, ::SysStringLen(aIn));
 }
 
-/* static */ HRESULT TextChange::SegCopy(IA2TextSegment& aDest,
-                                         const IA2TextSegment& aSrc) {
+/* static */
+HRESULT TextChange::SegCopy(IA2TextSegment& aDest, const IA2TextSegment& aSrc) {
   aDest = {BSTRCopy(aSrc.text), aSrc.start, aSrc.end};
   if (aSrc.text && !aDest.text) {
     return E_OUTOFMEMORY;
   }
   if (!::SysStringLen(aDest.text)) {
     return S_FALSE;
   }
   return S_OK;
--- a/accessible/windows/msaa/AccessibleWrap.cpp
+++ b/accessible/windows/msaa/AccessibleWrap.cpp
@@ -1540,27 +1540,29 @@ void AccessibleWrap::UpdateSystemCaretFo
     return;
   }
 
   HWND caretWnd =
       reinterpret_cast<HWND>(widget->GetNativeData(NS_NATIVE_WINDOW));
   UpdateSystemCaretFor(caretWnd, caretRect);
 }
 
-/* static */ void AccessibleWrap::UpdateSystemCaretFor(
+/* static */
+void AccessibleWrap::UpdateSystemCaretFor(
     ProxyAccessible* aProxy, const LayoutDeviceIntRect& aCaretRect) {
   ::DestroyCaret();
 
   // The HWND should be the real widget HWND, not an emulated HWND.
   // We get the HWND from the proxy's outer doc to bypass window emulation.
   Accessible* outerDoc = aProxy->OuterDocOfRemoteBrowser();
   UpdateSystemCaretFor(GetHWNDFor(outerDoc), aCaretRect);
 }
 
-/* static */ void AccessibleWrap::UpdateSystemCaretFor(
+/* static */
+void AccessibleWrap::UpdateSystemCaretFor(
     HWND aCaretWnd, const LayoutDeviceIntRect& aCaretRect) {
   if (!aCaretWnd || aCaretRect.IsEmpty()) {
     return;
   }
 
   // Create invisible bitmap for caret, otherwise its appearance interferes
   // with Gecko caret
   nsAutoBitmap caretBitMap(CreateBitmap(1, aCaretRect.Height(), 1, 1, nullptr));
@@ -1700,17 +1702,17 @@ bool AccessibleWrap::DispatchTextChangeT
   HRESULT hr = ASYNC_INVOKE(invoker, OnTextChange, PtrToLong(hwnd), msaaId,
                             isInsert, &textSegment);
 
   ::SysFreeString(textSegment.text);
 
   return SUCCEEDED(hr);
 }
 
-/* static */ void AccessibleWrap::AssignChildIDTo(
-    NotNull<sdnAccessible*> aSdnAcc) {
+/* static */
+void AccessibleWrap::AssignChildIDTo(NotNull<sdnAccessible*> aSdnAcc) {
   aSdnAcc->SetUniqueID(sIDGen.GetID());
 }
 
-/* static */ void AccessibleWrap::ReleaseChildID(
-    NotNull<sdnAccessible*> aSdnAcc) {
+/* static */
+void AccessibleWrap::ReleaseChildID(NotNull<sdnAccessible*> aSdnAcc) {
   sIDGen.ReleaseID(aSdnAcc);
 }
--- a/accessible/windows/msaa/Compatibility.cpp
+++ b/accessible/windows/msaa/Compatibility.cpp
@@ -161,17 +161,18 @@ DetectInSendMessageExCompat(PEXCEPTION_P
   return EXCEPTION_CONTINUE_SEARCH;
 }
 
 uint32_t Compatibility::sConsumers = Compatibility::UNKNOWN;
 
 /**
  * This function is safe to call multiple times.
  */
-/* static */ void Compatibility::InitConsumers() {
+/* static */
+void Compatibility::InitConsumers() {
   HMODULE jawsHandle = ::GetModuleHandleW(L"jhook");
   if (jawsHandle) {
     sConsumers |=
         IsModuleVersionLessThan(jawsHandle, MAKE_FILE_VERSION(19, 0, 0, 0))
             ? OLDJAWS
             : JAWS;
   }
 
@@ -198,17 +199,18 @@ uint32_t Compatibility::sConsumers = Com
       ::GetModuleHandleW(L"uiautomationcore"))
     sConsumers |= UIAUTOMATION;
 
   // If we have a known consumer remove the unknown bit.
   if (sConsumers != Compatibility::UNKNOWN)
     sConsumers &= ~Compatibility::UNKNOWN;
 }
 
-/* static */ bool Compatibility::HasKnownNonUiaConsumer() {
+/* static */
+bool Compatibility::HasKnownNonUiaConsumer() {
   InitConsumers();
   return sConsumers & ~(Compatibility::UNKNOWN | UIAUTOMATION);
 }
 
 void Compatibility::Init() {
   // Note we collect some AT statistics/telemetry here for convenience.
   InitConsumers();
 
--- a/dom/media/webrtc/MediaEngineTabVideoSource.cpp
+++ b/dom/media/webrtc/MediaEngineTabVideoSource.cpp
@@ -318,33 +318,36 @@ void MediaEngineTabVideoSource::Draw() {
     }
   }
 
   if (!mImageContainer) {
     mImageContainer = layers::LayerManager::CreateImageContainer(
         layers::ImageContainer::ASYNCHRONOUS);
   }
 
-  RefPtr<layers::SharedRGBImage> rgbImage = mImageContainer->CreateSharedRGBImage();
+  RefPtr<layers::SharedRGBImage> rgbImage =
+      mImageContainer->CreateSharedRGBImage();
   if (!rgbImage) {
     NS_WARNING("Failed to create SharedRGBImage");
     return;
   }
   if (!rgbImage->Allocate(size, SurfaceFormat::B8G8R8X8)) {
     NS_WARNING("Failed to allocate a shared image");
     return;
   }
 
-  RefPtr<layers::TextureClient> texture = rgbImage->GetTextureClient(/* aForwarder */nullptr);
+  RefPtr<layers::TextureClient> texture =
+      rgbImage->GetTextureClient(/* aForwarder */ nullptr);
   if (!texture) {
     NS_WARNING("Failed to allocate TextureClient");
     return;
   }
 
-  layers::TextureClientAutoLock autoLock(texture, layers::OpenMode::OPEN_WRITE_ONLY);
+  layers::TextureClientAutoLock autoLock(texture,
+                                         layers::OpenMode::OPEN_WRITE_ONLY);
   if (!autoLock.Succeeded()) {
     NS_WARNING("Failed to lock TextureClient");
     return;
   }
 
   RefPtr<gfx::DrawTarget> dt = texture->BorrowDrawTarget();
   if (!dt || !dt->IsValid()) {
     NS_WARNING("Failed to borrow DrawTarget");