Bug 520209 - active tab indication is too subtle / cannot see the tab focus outline (activity, contrast, invisible) [r=gavin.sharp]
authorMark Finkle <mfinkle@mozilla.com>
Wed, 02 Dec 2009 22:46:30 -0500
changeset 65883 2ebc8e493c7fdf0bdcd3b655fa49590f5430f968
parent 65882 25b706d6adc12e810a6856f1a43948527ec55a83
child 65884 4af3a4c03fa7f63cd75aee2a9e695170f2b0a558
push id1
push userroot
push dateTue, 26 Apr 2011 22:38:44 +0000
treeherdermozilla-beta@bfdb6e623a36 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgavin
bugs520209
Bug 520209 - active tab indication is too subtle / cannot see the tab focus outline (activity, contrast, invisible) [r=gavin.sharp]
mobile/themes/hildon/browser.css
mobile/themes/wince/browser-high.css
mobile/themes/wince/browser-low.css
mobile/themes/wince/browser.css
--- a/mobile/themes/hildon/browser.css
+++ b/mobile/themes/hildon/browser.css
@@ -698,18 +698,22 @@ box[type="documenttab"] {
 
 box[type="documenttab"] .documenttab-canvas {
   /* keep the unselected thumbnails aligned with the selected one */
   border: 8px solid #36373b;
   background-color: white;
 }
 
 box[type="documenttab"][selected="true"] .documenttab-canvas {
-  border: 8px solid #0c0d10; /* very dark border */
+  border: 8px solid;
   -moz-border-radius: 3px;
+  -moz-border-top-colors: #8db8d8 #8db8d8 #8db8d8 #8db8d8 #36373b;
+  -moz-border-right-colors: #8db8d8 #8db8d8 #8db8d8 #8db8d8 #36373b;
+  -moz-border-bottom-colors: #8db8d8 #8db8d8 #8db8d8 #8db8d8 #36373b;
+  -moz-border-left-colors: #8db8d8 #8db8d8 #8db8d8 #8db8d8 #36373b;
 }
 
 box[type="documenttab"] .documenttab-close {
   width: 40px;
   height: 40px;
   list-style-image: url("chrome://browser/skin/images/close-40.png");
 }
 
--- a/mobile/themes/wince/browser-high.css
+++ b/mobile/themes/wince/browser-high.css
@@ -284,16 +284,31 @@ placeitem[src=""] .bookmark-item-label >
 }
 
 autocompleteresult.allbookmarks > .autocomplete-item-label > image {
   width: 44px;
   height: 30px;
   list-style-image: url(images/bookmarks-30.png);
 }
 
+/* Left sidebar (tabs)  ---------------------------------------------------- */
+box[type="documenttab"] .documenttab-canvas {
+  /* keep the unselected thumbnails aligned with the selected one */
+  border: 8px solid #36373b;
+}
+
+box[type="documenttab"][selected="true"] .documenttab-canvas {
+  border: 8px solid;
+  -moz-border-radius: 3px;
+  -moz-border-top-colors: #8db8d8 #8db8d8 #8db8d8 #8db8d8 #36373b;
+  -moz-border-right-colors: #8db8d8 #8db8d8 #8db8d8 #8db8d8 #36373b;
+  -moz-border-bottom-colors: #8db8d8 #8db8d8 #8db8d8 #8db8d8 #36373b;
+  -moz-border-left-colors: #8db8d8 #8db8d8 #8db8d8 #8db8d8 #36373b;
+}
+
 box[type="documenttab"] .documenttab-close {
   width: 40px;
   height: 40px;
   list-style-image: url("chrome://browser/skin/images/close-40.png");
 }
 
 #newtab-button {
   list-style-image: url("images/newtab-default-64.png");
--- a/mobile/themes/wince/browser-low.css
+++ b/mobile/themes/wince/browser-low.css
@@ -284,16 +284,30 @@ placeitem[src=""] .bookmark-item-label >
 
 autocompleteresult.allbookmarks > .autocomplete-item-label > image {
   width: 35px;
   height: 24px;
   list-style-image: url(images/bookmarks-24.png);
 }
 
 /* Left sidebar (tabs)  ---------------------------------------------------- */
+box[type="documenttab"] .documenttab-canvas {
+  /* keep the unselected thumbnails aligned with the selected one */
+  border: 4px solid #36373b;
+}
+
+box[type="documenttab"][selected="true"] .documenttab-canvas {
+  border: 4px solid;
+  -moz-border-radius: 3px;
+  -moz-border-top-colors: #8db8d8 #8db8d8 #36373b;
+  -moz-border-right-colors: #8db8d8 #8db8d8 #36373b;
+  -moz-border-bottom-colors: #8db8d8 #8db8d8 #36373b;
+  -moz-border-left-colors: #8db8d8 #8db8d8 #36373b;
+}
+
 box[type="documenttab"] .documenttab-close {
   width: 16px;
   height: 17px;
   list-style-image: url("chrome://browser/skin/images/close-16.png");
 }
 
 #newtab-button {
   list-style-image: url("images/newtab-default-36.png");
--- a/mobile/themes/wince/browser.css
+++ b/mobile/themes/wince/browser.css
@@ -431,26 +431,19 @@ autocompleteresult.allbookmarks > .autoc
 }
 
 #tabs-controls {
   margin-top: 1.1mm; /* core spacing */
   -moz-box-pack: start;
 }
 
 box[type="documenttab"] .documenttab-canvas {
-  /* keep the unselected thumbnails aligned with the selected one */
-  border: 0.8mm solid #36373b;
   background-color: white;
 }
 
-box[type="documenttab"][selected="true"] .documenttab-canvas {
-  border: 0.8mm solid #0c0d10; /* very dark border */
-  -moz-border-radius: 4px;
-}
-
 box[type="documenttab"]:only-child .documenttab-close {
   display: none;
 }
 
 /* bookmark editor   ------------------------------------------------------- */
 #bookmark-container {
   padding: 1.1mm; /* core spacing */
   background-image: url("chrome://browser/skin/images/panel-shadow.png");