Bug 864428 - Don't call hideContextUI in startup and tear down test helpers as it can cause random test timeouts. r=bbondy
authorJim Mathies <jmathies@mozilla.com>
Tue, 23 Apr 2013 08:51:03 -0500
changeset 140581 2e589018543e6a967699bc166f18d6641a751cb1
parent 140580 21bfc7e0effd0c538d27f7eb3d0952bf5f9494b4
child 140582 18bd842b2897fe0eda5e923449624a024c93500d
push id2579
push userakeybl@mozilla.com
push dateMon, 24 Jun 2013 18:52:47 +0000
treeherdermozilla-beta@b69b7de8a05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbbondy
bugs864428
milestone23.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 864428 - Don't call hideContextUI in startup and tear down test helpers as it can cause random test timeouts. r=bbondy
browser/metro/base/tests/mochitest/browser_selection_basic.js
browser/metro/base/tests/mochitest/browser_selection_frame_content.js
browser/metro/base/tests/mochitest/browser_selection_inputs.js
browser/metro/base/tests/mochitest/browser_selection_textarea.js
--- a/browser/metro/base/tests/mochitest/browser_selection_basic.js
+++ b/browser/metro/base/tests/mochitest/browser_selection_basic.js
@@ -20,31 +20,32 @@ function setUpAndTearDown() {
   emptyClipboard();
   if (gWindow)
     clearSelection(gWindow);
   if (gFrame)
     clearSelection(gFrame);
   yield waitForCondition(function () {
       return !SelectionHelperUI.isSelectionUIVisible;
     }, kCommonWaitMs, kCommonPollMs);
-  yield hideContextUI();
 }
 
 gTests.push({
   desc: "normalize browser",
   setUp: setUpAndTearDown,
   tearDown: setUpAndTearDown,
   run: function test() {
     info(chromeRoot + "browser_selection_basic.html");
     yield addTab(chromeRoot + "browser_selection_basic.html");
 
     yield waitForCondition(function () {
         return !StartUI.isStartPageVisible;
       }, 10000, 100);
 
+    yield hideContextUI();
+
     gWindow = Browser.selectedTab.browser.contentWindow;
     InputSourceHelper.isPrecise = false;
   },
 });
 
 gTests.push({
   desc: "tap-hold to select",
   setUp: setUpAndTearDown,
--- a/browser/metro/base/tests/mochitest/browser_selection_frame_content.js
+++ b/browser/metro/base/tests/mochitest/browser_selection_frame_content.js
@@ -20,31 +20,32 @@ function setUpAndTearDown() {
   emptyClipboard();
   if (gWindow)
     clearSelection(gWindow);
   if (gFrame)
     clearSelection(gFrame);
   yield waitForCondition(function () {
       return !SelectionHelperUI.isSelectionUIVisible;
     }, kCommonWaitMs, kCommonPollMs);
-  yield hideContextUI();
 }
 
 gTests.push({
   desc: "normalize browser",
   setUp: setUpAndTearDown,
   tearDown: setUpAndTearDown,
   run: function test() {
     info(chromeRoot + "browser_selection_frame_content.html");
     yield addTab(chromeRoot + "browser_selection_frame_content.html");
 
     yield waitForCondition(function () {
       return !StartUI.isStartPageVisible;
       }, 10000, 100);
 
+    yield hideContextUI();
+
     gWindow = Browser.selectedTab.browser.contentWindow;
     gFrame = gWindow.document.getElementById("frame1");
 
     InputSourceHelper.isPrecise = false;
   },
 });
 
 gTests.push({
--- a/browser/metro/base/tests/mochitest/browser_selection_inputs.js
+++ b/browser/metro/base/tests/mochitest/browser_selection_inputs.js
@@ -20,17 +20,16 @@ function setUpAndTearDown() {
   emptyClipboard();
   if (gWindow)
     clearSelection(gWindow);
   if (gInput)
     clearSelection(gInput);
   yield waitForCondition(function () {
       return !SelectionHelperUI.isSelectionUIVisible;
     }, kCommonWaitMs, kCommonPollMs);
-  yield hideContextUI();
 }
 
 /*
   5px top margin
   25px tall text input
   300px wide
 */
 
@@ -41,16 +40,18 @@ gTests.push({
   run: function test() {
     info(chromeRoot + "browser_selection_inputs.html");
     yield addTab(chromeRoot + "browser_selection_inputs.html");
 
     yield waitForCondition(function () {
       return !StartUI.isStartPageVisible;
       }, 10000, 100);
 
+    yield hideContextUI();
+
     gWindow = Browser.selectedTab.browser.contentWindow;
     gInput = gWindow.document.getElementById("a");
     InputSourceHelper.isPrecise = false;
   },
 });
 
 gTests.push({
   desc: "basic text input selection",
--- a/browser/metro/base/tests/mochitest/browser_selection_textarea.js
+++ b/browser/metro/base/tests/mochitest/browser_selection_textarea.js
@@ -20,31 +20,32 @@ function setUpAndTearDown() {
   emptyClipboard();
   if (gWindow)
     clearSelection(gWindow);
   if (gFrame)
     clearSelection(gFrame);
   yield waitForCondition(function () {
       return !SelectionHelperUI.isSelectionUIVisible;
     }, kCommonWaitMs, kCommonPollMs);
-  yield hideContextUI();
 }
 
 gTests.push({
   desc: "normalize browser",
   setUp: setUpAndTearDown,
   tearDown: setUpAndTearDown,
   run: function test() {
     info(chromeRoot + "browser_selection_textarea.html");
     yield addTab(chromeRoot + "browser_selection_textarea.html");
 
     yield waitForCondition(function () {
       return !StartUI.isStartPageVisible;
       }, 10000, 100);
 
+    yield hideContextUI();
+
     gWindow = Browser.selectedTab.browser.contentWindow;
     InputSourceHelper.isPrecise = false;
   },
 });
 
 gTests.push({
   desc: "textarea basic selection",
   setUp: setUpAndTearDown,