Bug 897484 - followup: root newly added code to fix bustage on a CLOSED TREE.
authorMs2ger <ms2ger@gmail.com>
Mon, 29 Jul 2013 18:27:04 +0200
changeset 152636 2e2955849611202c91068078ab114fd8d6d22a77
parent 152635 6d171bc596748ebd3334dacbba73d72c42e7bb30
child 152650 5065fdc124082ebe40091abdf6648ce67c340656
child 152664 398c7364058619c1de658f6581d630d861d93131
child 152686 1279664e0d41273c4bbee2755d4c8a17bb7c5564
push id2859
push userakeybl@mozilla.com
push dateMon, 16 Sep 2013 19:14:59 +0000
treeherdermozilla-beta@87d3c51cd2bf [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs897484
milestone25.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 897484 - followup: root newly added code to fix bustage on a CLOSED TREE.
dom/bluetooth/MediaMetaData.cpp
dom/bluetooth/MediaPlayStatus.cpp
--- a/dom/bluetooth/MediaMetaData.cpp
+++ b/dom/bluetooth/MediaMetaData.cpp
@@ -34,17 +34,17 @@ MediaMetaData::Init(JSContext* aCx, cons
     return aVal->isNullOrUndefined() ? NS_OK : NS_ERROR_TYPE_ERR;
   }
 
   JS::RootedObject obj(aCx, &aVal->toObject());
   nsCxPusher pusher;
   pusher.Push(aCx);
   JSAutoCompartment ac(aCx, obj);
 
-  JS::Value value;
+  JS::Rooted<JS::Value> value(aCx);
   NS_ENSURE_STATE(JS_GetProperty(aCx, obj, "mAlbum", &value));
   if (JSVAL_IS_STRING(value)) {
     nsDependentJSString jsString;
     NS_ENSURE_STATE(jsString.init(aCx, value.toString()));
     mAlbum = jsString;
   }
 
   NS_ENSURE_STATE(JS_GetProperty(aCx, obj, "mArtist", &value));
--- a/dom/bluetooth/MediaPlayStatus.cpp
+++ b/dom/bluetooth/MediaPlayStatus.cpp
@@ -33,17 +33,17 @@ MediaPlayStatus::Init(JSContext* aCx, co
     return aVal->isNullOrUndefined() ? NS_OK : NS_ERROR_TYPE_ERR;
   }
 
   JS::RootedObject obj(aCx, &aVal->toObject());
   nsCxPusher pusher;
   pusher.Push(aCx);
   JSAutoCompartment ac(aCx, obj);
 
-  JS::Value value;
+  JS::Rooted<JS::Value> value(aCx);
   NS_ENSURE_STATE(JS_GetProperty(aCx, obj, "mDuration", &value));
   if (JSVAL_IS_INT(value)) {
     NS_ENSURE_STATE(JS_ValueToInt64(aCx, value, &mDuration));
   }
 
   NS_ENSURE_STATE(JS_GetProperty(aCx, obj, "mPlayStatus", &value));
   if (JSVAL_IS_STRING(value)) {
     nsDependentJSString jsString;